xenapi: Report better error when live migration will fail due to destination host not configured correctly

[Christopher Lefelhocz]

A live migration will fail due to the destination host having the management configured with an IP. The error returns at the xen layer is like the following example:

2013-10-13 19:14:30.074 28392 ERROR nova.openstack.common.rpc.common [req-221976a9-d5e2-4ab7-81cb-38ef112ab965 XXXXX XXXXXX] Returning exception Migration pre-check error: Migrate Receive failed to caller

Further investigation into the xen log resulted in a PIF not being configured with the IP. This check can happen prior the Xen call and we can be more informative in failing the check.

See https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vmops.py#L1844 for place where we can be more descriptive.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/54327

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54327
Committed: http://github.com/openstack/nova/commit/8e4fc4734852b6bcf1a6844f89bcd3dfae2e5086
Submitter: Jenkins
Branch: master

commit 8e4fc4734852b6bcf1a6844f89bcd3dfae2e5086
Author: Christopher Lefelhocz <email address hidden>
Date: Tue Oct 29 01:10:48 2013 +0000

    xenapi: check for IP address in live migration pre check

    A requirement for live migration is that the destination
    host contains a management PIF with an IP address assigned.
    If a host is broken (no IP), the compute log simply shows a generic
    exception on the xenapi call host.migrate_receive. We can
    provide better information that the IP address is missing
    by checking this prior to the call.

    Closes-Bug: 1245592

    Change-Id: Iaa6345f4bddf2f98efb4a5c9743da16ba8ae7b56