traces with AppArmor and self-compiled kernel 3.11.0-12.19

[Kai Raven]

Description: Ubuntu 13.10
Release: 13.10
linux-image-3.11.0-12-generic:
Installed: 3.11.0-12.19

After apt-get source linux-image-3.11.0-12-generic and successful completed kernel compilations (s. attachments for the last config), i get always messages like the following in /var/log/syslog after boot. With the standard kernel no problems:

Oct 23 16:54:16 srunner kernel: [ 5985.900701] WARNING: CPU: 0 PID: 3 at /opt/linux-3.11.0/security/apparmor/label.c:226 __aa_label_remove+0x45/0x100()
Oct 23 16:54:16 srunner kernel: [ 5985.900706] AppArmor WARN __aa_label_remove: (((((void)(&(&ls->lock)->raw_lock), 1)))):
Oct 23 16:54:16 srunner kernel: [ 5985.900709] Modules linked in: xt_LOG xt_multiport xt_limit nvidia(PO) xt_addrtype xt_nat xt_tcpudp xt_conntrack ip6_tables nf_nat_ftp nf_conntrack_ftp drm vboxnetflt(O) vboxnetadp(O) vboxpci(O) vboxdrv(O) ipt_REJECT xt_REDIRECT xt_recent xt_iprange xt_mark xt_NFQUEUE nfnetlink_queue nfnetlink iptable_raw iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_filter ip_tables x_tables dm_crypt vesafb cfbfillrect cfbimgblt cfbcopyarea
Oct 23 16:54:16 srunner kernel: [ 5985.900758] CPU: 0 PID: 3 Comm: ksoftirqd/0 Tainted: P W O 3.11.0-12-matrix #19
Oct 23 16:54:16 srunner kernel: [ 5985.900763] Hardware name: HP Pavilion 061 EP127AA-ABD t3350.de/AMETHYST-M, BIOS 3.47 03/03/2006
Oct 23 16:54:16 srunner kernel: [ 5985.900767] f5c83e78 f5c83e78 f5c83e38 c14a405a f5c83e68 c102f650 c1616ebc f5c83e94
Oct 23 16:54:16 srunner kernel: [ 5985.900775] 00000003 c1616e6c 000000e2 c12239f5 c12239f5 f47ed018 f5c05850 00000001
Oct 23 16:54:16 srunner kernel: [ 5985.900783] f5c83e80 c102f6a3 00000009 f5c83e78 c1616ebc f5c83e94 f5c83ea0 c12239f5
Oct 23 16:54:16 srunner kernel: [ 5985.900792] Call Trace:
Oct 23 16:54:16 srunner kernel: [ 5985.900801] [<c14a405a>] dump_stack+0x16/0x18
Oct 23 16:54:16 srunner kernel: [ 5985.900809] [<c102f650>] warn_slowpath_common+0x80/0xa0
Oct 23 16:54:16 srunner kernel: [ 5985.900817] [<c12239f5>] ? __aa_label_remove+0x45/0x100
Oct 23 16:54:16 srunner kernel: [ 5985.900824] [<c12239f5>] ? __aa_label_remove+0x45/0x100
Oct 23 16:54:16 srunner kernel: [ 5985.900830] [<c102f6a3>] warn_slowpath_fmt+0x33/0x40
Oct 23 16:54:16 srunner kernel: [ 5985.900837] [<c12239f5>] __aa_label_remove+0x45/0x100
Oct 23 16:54:16 srunner kernel: [ 5985.900843] [<c1224271>] aa_label_remove+0x11/0x20
Oct 23 16:54:16 srunner kernel: [ 5985.900848] [<c12242a3>] aa_label_kref+0x23/0x50
Oct 23 16:54:16 srunner kernel: [ 5985.900854] [<c121ad35>] aa_free_task_context+0x75/0x80
Oct 23 16:54:16 srunner kernel: [ 5985.900861] [<c1220af3>] apparmor_cred_free+0x13/0x20
Oct 23 16:54:16 srunner kernel: [ 5985.900868] [<c1217234>] security_cred_free+0x14/0x20
Oct 23 16:54:16 srunner kernel: [ 5985.900874] [<c104f400>] put_cred_rcu+0x20/0x90
Oct 23 16:54:16 srunner kernel: [ 5985.900880] [<c102f945>] ? delayed_put_task_struct+0x35/0x70
Oct 23 16:54:16 srunner kernel: [ 5985.900887] [<c109935a>] __rcu_process_callbacks+0x3a/0x80
Oct 23 16:54:16 srunner kernel: [ 5985.900893] [<c10993b2>] rcu_process_callbacks+0x12/0x20
Oct 23 16:54:16 srunner kernel: [ 5985.900901] [<c1033430>] __do_softirq+0xb0/0x1c0
Oct 23 16:54:16 srunner kernel: [ 5985.900908] [<c14a7ce9>] ? apic_timer_interrupt+0x31/0x38
Oct 23 16:54:16 srunner kernel: [ 5985.900916] [<c1033568>] run_ksoftirqd+0x28/0x40
Oct 23 16:54:16 srunner kernel: [ 5985.900922] [<c105118e>] smpboot_thread_fn+0xde/0x110
Oct 23 16:54:16 srunner kernel: [ 5985.900928] [<c10510b0>] ? lg_global_unlock+0x10/0x10
Oct 23 16:54:16 srunner kernel: [ 5985.900934] [<c104a4b3>] kthread+0x93/0xa0
Oct 23 16:54:16 srunner kernel: [ 5985.900942] [<c14a81f7>] ret_from_kernel_thread+0x1b/0x28
Oct 23 16:54:16 srunner kernel: [ 5985.900947] [<c104a420>] ? kthread_worker_fn+0xf0/0xf0
Oct 23 16:54:16 srunner kernel: [ 5985.900952] ---[ end trace 6459271422b49c3d ]---
Oct 23 17:14:08 srunner kernel: [ 7177.268576] WARNING: CPU: 0 PID: 9301 at /opt/linux-3.11.0/security/apparmor/label.c:270 aa_label_replace+0x8f/0x210()
Oct 23 17:14:08 srunner kernel: [ 7177.268578] AppArmor WARN __aa_label_replace: (((((void)(&(&ls->lock)->raw_lock), 1)))):
Oct 23 17:14:08 srunner kernel: [ 7177.268580] Modules linked in: xt_LOG xt_multiport xt_limit nvidia(PO) xt_addrtype xt_nat xt_tcpudp xt_conntrack ip6_tables nf_nat_ftp nf_conntrack_ftp drm vboxnetflt(O) vboxnetadp(O) vboxpci(O) vboxdrv(O) ipt_REJECT xt_REDIRECT xt_recent xt_iprange xt_mark xt_NFQUEUE nfnetlink_queue nfnetlink iptable_raw iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_filter ip_tables x_tables dm_crypt vesafb cfbfillrect cfbimgblt cfbcopyarea
Oct 23 17:14:08 srunner kernel: [ 7177.268606] CPU: 0 PID: 9301 Comm: apparmor_parser Tainted: P W O 3.11.0-12-matrix #19
Oct 23 17:14:08 srunner kernel: [ 7177.268609] Hardware name: HP Pavilion 061 EP127AA-ABD t3350.de/AMETHYST-M, BIOS 3.47 03/03/2006
Oct 23 17:14:08 srunner kernel: [ 7177.268610] d8113ec4 d8113ec4 d8113e84 c14a405a d8113eb4 c102f650 c1616ebc d8113ee0
Oct 23 17:14:08 srunner kernel: [ 7177.268615] 00002455 c1616e6c 0000010e c122461f c122461f ec67cc18 f1e89018 00000286
Oct 23 17:14:08 srunner kernel: [ 7177.268618] d8113ecc c102f6a3 00000009 d8113ec4 c1616ebc d8113ee0 d8113ef4 c122461f
Oct 23 17:14:08 srunner kernel: [ 7177.268622] Call Trace:
Oct 23 17:14:08 srunner kernel: [ 7177.268628] [<c14a405a>] dump_stack+0x16/0x18
Oct 23 17:14:08 srunner kernel: [ 7177.268633] [<c102f650>] warn_slowpath_common+0x80/0xa0
Oct 23 17:14:08 srunner kernel: [ 7177.268635] [<c122461f>] ? aa_label_replace+0x8f/0x210
Oct 23 17:14:08 srunner kernel: [ 7177.268638] [<c122461f>] ? aa_label_replace+0x8f/0x210
Oct 23 17:14:08 srunner kernel: [ 7177.268641] [<c102f6a3>] warn_slowpath_fmt+0x33/0x40
Oct 23 17:14:08 srunner kernel: [ 7177.268643] [<c122461f>] aa_label_replace+0x8f/0x210
Oct 23 17:14:08 srunner kernel: [ 7177.268647] [<c121eef5>] aa_replace_profiles+0x615/0x970
Oct 23 17:14:08 srunner kernel: [ 7177.268651] [<c10f7a18>] ? vmalloc+0x38/0x40
Oct 23 17:14:08 srunner kernel: [ 7177.268655] [<c1219630>] ? profile_remove+0x50/0x50
Oct 23 17:14:08 srunner kernel: [ 7177.268658] [<c1219665>] profile_replace+0x35/0x50
Oct 23 17:14:08 srunner kernel: [ 7177.268662] [<c11139ec>] vfs_write+0x9c/0x1a0
Oct 23 17:14:08 srunner kernel: [ 7177.268664] [<c1219630>] ? profile_remove+0x50/0x50
Oct 23 17:14:08 srunner kernel: [ 7177.268667] [<c111402f>] SyS_write+0x4f/0xa0
Oct 23 17:14:08 srunner kernel: [ 7177.268671] [<c14a827b>] sysenter_do_call+0x12/0x22
Oct 23 17:14:08 srunner kernel: [ 7177.268674] ---[ end trace 6459271422b49c3e ]---
Oct 23 17:14:08 srunner kernel: [ 7177.268679] ------------[ cut here ]------------

[John Johansen (jjohansen)]

I've traced this down to the
  write_can_lock() macro not working correctly in non-smp kernels

the following patch is needed

diff --git a/security/apparmor/label.c b/security/apparmor/label.c
index 788ec21..39eae14 100644
--- a/security/apparmor/label.c
+++ b/security/apparmor/label.c
@@ -19,6 +19,10 @@
 #include "include/policy.h"
 #include "include/sid.h"

+#if !defined(CONFIG_SMP)
+#undef write_can_lock
+#define write_can_lock(X) 0
+#endif

 /*
  * the aa_label represents the set of profiles confining an object

[Kai Raven (kr-aven)]

Hi John,

yes, i saw it in label.c, but didn't know what to to ;)
Great, thank you for the patch - kernel compiled and started without problems :)