cinder backup should use pipe for diff transfer

Bug #1244464 reported by Edward Hope-Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Edward Hope-Morley
Havana
Fix Released
Critical
Edward Hope-Morley
cinder (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When the cinder ceph backup driver attempts a differential transfer, the diff is held in memory. This will rapidly become a problem e.g. for bootable volumes, resulting in memory allocation errors.

summary: - cinder backup should use tmp file for diff transfer
+ cinder backup should use pipe for diff transfer
description: updated
Changed in cinder:
status: New → In Progress
assignee: nobody → Edward Hope-Morley (hopem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53923

Josh Durgin (jdurgin)
Changed in cinder:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/53923
Committed: http://github.com/openstack/cinder/commit/d384d28e1c2c7c3ce0bd676fb1c2bdb8a2d98a03
Submitter: Jenkins
Branch: master

commit d384d28e1c2c7c3ce0bd676fb1c2bdb8a2d98a03
Author: Edward Hope-Morley <email address hidden>
Date: Fri Oct 25 10:57:55 2013 -0700

    Use pipe between ceph backup diff export/import

    We now use a piped transfer between the rbd export-diff
    and import-diff for incremental backups/restores as
    opposed to holding the entire diff in memory.

    Change-Id: I33476d9b3934781413af5cd2867a11d825a5d78e
    Fixes: bug 1244464

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Now that this has been appoved, I will nominate it for backport to stable/havana

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/54589

Changed in cinder:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/havana)

Reviewed: https://review.openstack.org/54589
Committed: http://github.com/openstack/cinder/commit/022f1df261d15ca8faa89382974e772473bce69d
Submitter: Jenkins
Branch: stable/havana

commit 022f1df261d15ca8faa89382974e772473bce69d
Author: Edward Hope-Morley <email address hidden>
Date: Fri Oct 25 10:57:55 2013 -0700

    Use pipe between ceph backup diff export/import

    We now use a piped transfer between the rbd export-diff
    and import-diff for incremental backups/restores as
    opposed to holding the entire diff in memory.

    Change-Id: I33476d9b3934781413af5cd2867a11d825a5d78e
    Fixes: bug 1244464
    (cherry picked from commit d384d28e1c2c7c3ce0bd676fb1c2bdb8a2d98a03)

Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-1 → 2014.1
Paul White (paulw2u)
affects: ubuntu → cinder (Ubuntu)
Changed in cinder (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.