Make snapshot force parameter boolean

Bug #1244453 reported by Edward Hope-Morley
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Low
Mike Perez

Bug Description

the --force parameter used in cinderclient commands is currently string which makes no sense since it is inherentlty boolean.

Let's make sure that for the next api version bump we fix this.

Tags: api
Revision history for this message
Edward Hope-Morley (hopem) wrote :

e.g. metavar='<True|False>' should be action=store_true,

Changed in python-cinderclient:
status: New → In Progress
assignee: nobody → Edward Hope-Morley (hopem)
Changed in python-cinderclient:
status: In Progress → New
assignee: Edward Hope-Morley (hopem) → nobody
description: updated
Changed in python-cinderclient:
importance: Undecided → Low
Changed in python-cinderclient:
assignee: nobody → Qiang Zhang (strony-zhang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80954

Revision history for this message
Qiang Zhang (strony-zhang) wrote :
Changed in python-cinderclient:
status: New → In Progress
tags: added: api
yatin (yatinkarel)
Changed in python-cinderclient:
assignee: Qiang Zhang (strony-zhang) → yatin (yatinkarel)
Revision history for this message
yatin (yatinkarel) wrote :
Changed in python-cinderclient:
assignee: yatin (yatinkarel) → Mike Perez (thingee)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/170724
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=c15ab5b557ca016605724377982521ec0d311277
Submitter: Jenkins
Branch: master

commit c15ab5b557ca016605724377982521ec0d311277
Author: yatin karel <email address hidden>
Date: Sun Apr 5 21:07:31 2015 +0530

    Change --force parameter into boolean

    Change --force parameter into boolean, now user can use it as boolean,
    without specifying True or False with it. It is still backward
    compatible with --force True|False. This can be deprecated in future.

    Closes-Bug: #1244453
    Change-Id: Id245af1fa0db27912439a420c37aefca530894ba

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.