check_ssh_injection not handling quoted args correctly

[Matthew Edmonds]

check_ssh_injection in cinder/utils.py is disallowing args with spaces even when the arg is quoted. This leads to an SSHInjectionThreat being raised when a volume driver needs to send a quoted arg containing spaces, e.g. when a storage pool name contains a space.

[Luis A. Garcia (luisg-8)]

https://review.openstack.org/#/c/54405/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54405
Committed: http://github.com/openstack/cinder/commit/2737c76cb2fb436f117a4f635aebca7a01691d88
Submitter: Jenkins
Branch: master

commit 2737c76cb2fb436f117a4f635aebca7a01691d88
Author: Luis A. Garcia <email address hidden>
Date: Tue Oct 29 18:44:12 2013 +0000

    Allow spaces in quoted SSH command arguments

    The check_ssh_injection() method was rejecting arguments with spaces
    even when they were quoted, this was causing problems with some volume
    driver commands such as commands for a storage pool with spaces in the
    name.

    Closes-Bug: #1244415
    Change-Id: Ie4b809e1b39fdb752cf634e6d3c0a3924d8ac52b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/54762

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54762
Committed: http://github.com/openstack/cinder/commit/ff6d79005f517bb58f9f28a8187aa26fa1dbd64d
Submitter: Jenkins
Branch: stable/havana

commit ff6d79005f517bb58f9f28a8187aa26fa1dbd64d
Author: Luis A. Garcia <email address hidden>
Date: Tue Oct 29 18:44:12 2013 +0000

    Allow spaces in quoted SSH command arguments

    The check_ssh_injection() method was rejecting arguments with spaces
    even when they were quoted, this was causing problems with some volume
    driver commands such as commands for a storage pool with spaces in the
    name.

    Note that this backport also fixes a typo that has been fixed separately
    in master with commit eb0f2e4dd538a79184efbb23d7e404147dfe877b .

    Closes-Bug: #1244415
    Change-Id: Ie4b809e1b39fdb752cf634e6d3c0a3924d8ac52b
    (cherry picked from commit 2737c76cb2fb436f117a4f635aebca7a01691d88)