The browser doesn't need to store urls with 404 status in the history
Bug #1244335 reported by
Adnane Belmadiaf
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Riccardo Padovani | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Riccardo Padovani |
Bug Description
How to reproduce :
- Open "http://
- Click on the addressbar, type "test" this show you the url "http://
Related branches
lp:~rpadovani/oxide/http-status-code
- Olivier Tilloy (community): Approve
- Chris Coulson: Approve
-
Diff: 1034 lines (+612/-65)10 files modifiedqt/core/api/oxideqloadevent.cc (+17/-3)
qt/core/api/oxideqloadevent.h (+16/-3)
qt/core/browser/oxide_qt_web_view.cc (+17/-9)
qt/core/browser/oxide_qt_web_view.h (+8/-4)
qt/qmlplugin/oxide_qml_plugin.cc (+2/-0)
qt/tests/qmltests/api/tst_LoadEvent_httpStatusCode.py (+21/-0)
qt/tests/qmltests/api/tst_LoadEvent_httpStatusCode.qml (+462/-0)
qt/tests/qmltests/api/tst_WebView_loading.qml (+33/-27)
shared/browser/oxide_web_view.cc (+25/-13)
shared/browser/oxide_web_view.h (+11/-6)
lp:~rpadovani/webbrowser-app/remove-404-history
- Olivier Tilloy: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 159 lines (+95/-5)5 files modifiedsrc/app/webbrowser/Browser.qml (+1/-1)
src/app/webbrowser/ExpandedHistoryView.qml (+1/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+27/-2)
tests/autopilot/webbrowser_app/tests/__init__.py (+3/-2)
tests/autopilot/webbrowser_app/tests/test_history.py (+63/-0)
summary: |
- The browser needs to not store urls with 404 status in the history + The browser doesn't need to store urls with 404 status in the history |
Changed in webbrowser-app: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in oxide: | |
assignee: | nobody → Riccardo Padovani (rpadovani) |
status: | Triaged → In Progress |
Changed in oxide: | |
status: | In Progress → Fix Released |
Changed in webbrowser-app: | |
status: | Confirmed → In Progress |
assignee: | nobody → Riccardo Padovani (rpadovani) |
Changed in webbrowser-app (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Riccardo Padovani (rpadovani) |
importance: | Undecided → Medium |
Changed in webbrowser-app: | |
assignee: | Riccardo Padovani (rpadovani) → nobody |
status: | In Progress → Invalid |
no longer affects: | webbrowser-app |
To post a comment you must log in.
In theory we should be able to filter out 404 URLs using the loadRequest. errorCode attribute in the onLoadingChanged handler (see http:// qt-project. org/doc/ qt-5.1/ qtwebkit/ qml-qtwebkit3- webview. html#onLoadingC hanged- signal), however in practice the errorCode seems to always be 0.