Evacuate operation should honor the enable_instance_password conf value

Bug #1244203 reported by GuoHui Liu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
GuoHui Liu

Bug Description

Currently the Evacuate operation (enabled by the os-evacuate) extension always returns a generated (or user supplied) password, although not all hypervisors support password injection.

For server create and rebuild and rescue operations the configuration option "enable_instance_password=False" can be used to suppress returning a meaningless and confusing password, and the evacuate operation should also honor this setting

Tags: api
GuoHui Liu (guohliu)
Changed in nova:
assignee: nobody → GuoHui LIu (guohliu)
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53775

Changed in nova:
status: New → In Progress
Revision history for this message
Andres Isaac Benavides (andres-i-benavides) wrote :

Just a question. Do you know why the code review expired after 1 week? Do you continue working on it bug?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/53775
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=73ee7346675ffb38276583ac7b941970f7037181
Submitter: Jenkins
Branch: master

commit 73ee7346675ffb38276583ac7b941970f7037181
Author: guohliu <email address hidden>
Date: Thu Oct 24 21:00:17 2013 +0800

    Fixes evacuate doesn't honor enable password conf for v3

    The evacuate api should honor enable_instance_password conf
    setting just like server creation, rebuild and rescue api does,
    enables this flag will returning the instance password from
    server API call evacuate, If the hypervisor does not support
    password injection then the password returned will not be
    correct, this patch just fixes v3 evacuate api, since change
    return value of v2 could potentially break apps which depend
    on this being returned.

    This patch also changes the evacuate response code to 202 to
    keep consistency with api.

    DocImpact
    Change-Id: I2b9e5a067323ca84e2040e175a0425de3c0fafba
    Closes-Bug: #1244203

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.