juju is stripping underscore from options

[David Ames]

juju is stripping underscore from options

Originally found in 0.2.3+bzr115-0~26~precise1ubuntu1~0.IS.12.04 and subsequently confirmed in latest source code

is-charms:
  series: precise
  services:
    is-charms-cassandra:
      num_units: 3
      charm: cassandra
      constraints: mem=4G
      options:
        extra-jvm-opts: -Djavaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar

juju get is-charms-cassandra

  extra-jvm-opts:
    description: 'string to be appended to JVM_OPTS, e.g.:

      -Djavaagent:$CASSANDRAHOME/lib/jamm-0.2.5.jar

Using double underscore "escapes"
is-charms:
  series: precise
  services:
    is-charms-cassandra:
      num_units: 3
      charm: cassandra
      constraints: mem=4G
      options:
        extra-jvm-opts: -Djavaagent:$CASSANDRA__HOME/lib/jamm-0.2.5.jar

juju get is-charms-cassandra

  extra-jvm-opts:
    description: 'string to be appended to JVM_OPTS, e.g.:

      -Djavaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar

[Jacek Nykis (jacekn)]

I experienced exactly the same problem. My config has:
nagios_check_https_params: "-H 127.0.0.1 --ssl -p {https_port}"

which ends up being:
value: -H 127.0.0.1 --ssl -p {httpsport}

[Kapil Thangavelu (hazmat)]

Its really unclear where this is happening, i'm writing a functional test to see if i can reproduce.

[Kapil Thangavelu (hazmat)]

so i've written a few tests, and i can't reproduce this. has anyone confirmed that this issues doesn't exist with juju-core by itself?

[Kapil Thangavelu (hazmat)]

confirmed. this is not an issue in deployer, its an issue in juju-core. it looks like core is stripping the underscore on the way in from a cli deploy --config config.yaml.. i've verified what deployer passes in is correct and that the resulting values for service config stored in mongodb have the values stripped.

[Abel Deuring (adeuring)]

This is acutally a bug in goyyaml. Fix coming soon.

[Abel Deuring (adeuring)]

Did double underscores really ever work? I tried to reproduce this workaround but can't get it working.

Wrapping the strings in question in quotation marks should work though.

Also, the root cause of the problem seems to be a bug in the function resolve() in the goyaml package, which removes _all_ underscores from a string if it starts with a digit or a '+' or '-'. (see the linked branch)

[Curtis Hovey (sinzui)]

The fix was made upstream, but the bug wrongly claimed to be invalid for juju-core. The bug does affect juju-core because it must update dependencies.tsv to to use the fix. The commit with the fix is 1418a9bc452f9cf4efa70307cafcb10743e64a56
    https://github.com/go-yaml/yaml/commit/1418a9bc452f9cf4efa70307cafcb10743e64a56#diff-d41d8cd98f00b204e9800998ecf8427e

[David Britton (dpb)]

I hit this using 1.20.4. I'm attching the debugging I did to make sure it's not lost. This error showed up not with juju get/set, but instead with jujud on the bootstrap node reading in the environment configuration: