Nova api doesn't start with a backdoor port set

[Matthew Treinish]

nova api fails to start properly if a backdoor port is specified. Looking at the logs this traceback is repeatedly printed:

2013-10-22 14:19:46.822 INFO nova.openstack.common.service [-] Child 1460 exited with status 1
2013-10-22 14:19:46.824 INFO nova.openstack.common.service [-] Started child 1468
2013-10-22 14:19:46.833 INFO nova.openstack.common.eventlet_backdoor [-] Eventlet backdoor listening on 60684 for process 1467
2013-10-22 14:19:46.833 INFO nova.openstack.common.eventlet_backdoor [-] Eventlet backdoor listening on 58986 for process 1468
2013-10-22 14:19:46.837 ERROR nova.openstack.common.threadgroup [-] 'NoneType' object has no attribute 'backdoor_port'
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup Traceback (most recent call last):
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 117, in wait
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup x.wait()
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 49, in wait
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup return self.thread.wait()
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/greenthread.py", line 168, in wait
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup return self._exit_event.wait()
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/event.py", line 116, in wait
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup return hubs.get_hub().switch()
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 187, in switch
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup return self.greenlet.switch()
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/greenthread.py", line 194, in main
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup result = function(*args, **kwargs)
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/service.py", line 448, in run_service
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup service.start()
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/service.py", line 357, in start
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup self.manager.backdoor_port = self.backdoor_port
2013-10-22 14:19:46.837 TRACE nova.openstack.common.threadgroup AttributeError: 'NoneType' object has no attribute 'backdoor_port'
2013-10-22 14:19:46.840 TRACE nova File "/usr/local/bin/nova-api", line 10, in <module>
2013-10-22 14:19:46.840 TRACE nova sys.exit(main())
2013-10-22 14:19:46.840 TRACE nova File "/opt/stack/nova/nova/cmd/api.py", line 53, in main
2013-10-22 14:19:46.840 TRACE nova launcher.wait()
2013-10-22 14:19:46.840 TRACE nova File "/opt/stack/nova/nova/openstack/common/service.py", line 351, in wait
2013-10-22 14:19:46.840 TRACE nova self._respawn_children()
2013-10-22 14:19:46.840 TRACE nova File "/opt/stack/nova/nova/openstack/common/service.py", line 341, in _respawn_children
2013-10-22 14:19:46.840 TRACE nova self._start_child(wrap)
2013-10-22 14:19:46.840 TRACE nova File "/opt/stack/nova/nova/openstack/common/service.py", line 287, in _start_child
2013-10-22 14:19:46.840 TRACE nova os._exit(status)
2013-10-22 14:19:46.840 TRACE nova TypeError: an integer is required
2013-10-22 14:19:46.840 TRACE nova

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/53141

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/53141
Committed: http://github.com/openstack/nova/commit/e5c96505c0b4eac51c0925dcb691f0a1699216ce
Submitter: Jenkins
Branch: master

commit e5c96505c0b4eac51c0925dcb691f0a1699216ce
Author: Matthew Treinish <email address hidden>
Date: Tue Oct 22 15:06:14 2013 +0000

    Fix setting backdoor port in service start

    Previously if self.manager wasn't defined for a Service object but a
    backdoor_port was specified then that particular service would not
    start because it would try to set the backdoor port in an object that
    didn't exist. This commit fixes setting the backdoor port only if
    manager is defined when calling start().

    Closes-Bug: #1243260

    Change-Id: Ib0e709cfd0e299a3e010450b7eba6e92bc108e4e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/54608

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54608
Committed: http://github.com/openstack/nova/commit/65135e70254e881af78be92fd32144da5d3467f0
Submitter: Jenkins
Branch: stable/havana

commit 65135e70254e881af78be92fd32144da5d3467f0
Author: Matthew Treinish <email address hidden>
Date: Tue Oct 22 15:06:14 2013 +0000

    Fix setting backdoor port in service start

    Previously if self.manager wasn't defined for a Service object but a
    backdoor_port was specified then that particular service would not
    start because it would try to set the backdoor port in an object that
    didn't exist. This commit fixes setting the backdoor port only if
    manager is defined when calling start().

    Closes-Bug: #1243260

    Change-Id: Ib0e709cfd0e299a3e010450b7eba6e92bc108e4e
    (cherry picked from commit e5c96505c0b4eac51c0925dcb691f0a1699216ce)