parameter checking about quota update api is incorrect

Bug #1243037 reported by Yuiko Takada
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Yuiko Takada

Bug Description

In this API, parameters are checked whether they are integer or not.
But when pass float values to this API, error doesn't occur.
Float values should be forbidden.

Changed in nova:
assignee: nobody → Yuiko Takada (takada-yuiko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53056

Changed in nova:
status: New → In Progress
summary: - parameter checking of quota_classes update api is incorrect
+ parameter checking about quota update api is incorrect
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/53056
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=01e1c027754b47239b9f9a6c40196512ec262986
Submitter: Jenkins
Branch: master

commit 01e1c027754b47239b9f9a6c40196512ec262986
Author: Yuiko Takada <email address hidden>
Date: Tue Oct 22 05:42:35 2013 +0000

    Fix parameter checking about quota update api

    In quota_classes and quotas update API, parameters are checked
    whether they are integer or not.
    But when pass float values to these APIs, error doesn't occur.
    Float values should be forbidden for the following reasons.
    (1)If the value that user submitted and the value registered
       actually are different, user will be confused.
    (2)Error messages of these APIs are "...must be integer...".
    (3)In horizon, if a float is submitted, error message is displayed.

    This patch fixes this problem.

    Change-Id: I4c7df52ffff2d997da4e6267e25ec2ea4ab6f153
    Closes-Bug: #1243037

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/57436
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2113dfd2e495fd9b4447522c8f0b6433609996b0
Submitter: Jenkins
Branch: master

commit 2113dfd2e495fd9b4447522c8f0b6433609996b0
Author: Chris Yeoh <email address hidden>
Date: Wed Nov 20 23:24:57 2013 +1030

    Handle UnicodeEncodeError in validate_integer

    validate_integer can be potentially passed user
    supplied data which causes a UnicodeEncodeError
    exception during validation rather than just ValueError.
    This change handles the UnicodeEncode exception
    so validate_integer treats it as invalid input.

    Change-Id: I5177789299b02448ed53e1b7fc23ccdaee1b70d3
    Partial-Bug: 1243037

Changed in nova:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/77035

Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/havana)

Change abandoned by Alan Pevec (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/77035
Reason: Final Havana release 2013.2.4 has been cut and stable/havana is going to be removed in a week.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.