delete operation in network topology should show a confirm dialog

[Akihiro Motoki]

When we click a delete operation in network topology, the corresponding delete operation is issued immediately.
Delete operation cannot be undone, so it is better to show a confirm dialog instead.
It brings us better consistency with delete operations in various tables.

[Babitha (babitha31)]

The templates of Network topology is SVG based.When we mouseover a particular instance or router,a balloon type object pops up.When we click on Terminate Instance,it is not getting redirected to any particular link or whatever to perform the deletion of VM as in Instances table,so no pop up of confirmation for deletion arises.
This occurs because of the logic in the respective JS file.i.e..,if the task is 'deleting',it posts the message to respective call and it terminates the instance and deletes the balloon object even.

[Facundo Farias (facundo-farias)]

Agreed with the previous comment, but instead of doing the post directly, we can create an small popup showing a confirmation dialog, and if it is Okay it should fire the 'same event' let's say. Is this bug work in progress?

[Akihiro Motoki (amotoki)]

I agree with the comment above. IMO any type of confirmation will work.

We don't see any progress over a month. We can switch the assignee if someone would like to work on it.

[Facundo Farias (facundo-farias)]

I can do it. Do we know which is the milestone for this bug?

[Victoria Martinez de la Cruz (vkmc)]

I was trying to reuse the confirmation dialog we use across Horizon in order to keep the consistency and avoid code duplication. Unfortunately, I don't have enough time to finish it. Looking forward to see it fixed :)

[Rajani Srivastava (srivastava-rajani)]

Hi Faris

Are you working on this bug ?
 I would like to work on this.

[Julie Pichon (jpichon)]

Hi Rajani,

It's been a long time, feel free to take on this bug! Thank you.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128873

[Timur Sufiev (tsufiev-x)]

Swati, the bug status is considered 'Fix Committed' as soon as the related change request in review.openstack.org is merged. Until then, it's still 'In Progress'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/131979

[OpenStack Infra (hudson-openstack)]

Change abandoned by Swati Shukla (<email address hidden>) on branch: master
Review: https://review.openstack.org/128873
Reason: Due to system breakdown, I am abandoning this change. I have created a new branch and submitted a fresh patch on https://review.openstack.org/131979. Please review the same.

[Swati Sharma (swati-shukla1)]

Initial Branch https://review.openstack.org/128873 is restored and Patch 4 uploaded on the same.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Swati Shukla (<email address hidden>) on branch: master
Review: https://review.openstack.org/131979
Reason: Started working on https://review.openstack.org/#/c/128873/ again, so abandoning this change.
Thanks.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/128873
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220766

[Timur Sufiev (tsufiev-x)]

Removing assignee due to 6 months period of inactivity.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290574

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/220766
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/290574
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Rob Cresswell (robcresswell-deactivatedaccount)]

Removed assignee due to inactivity

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/220766
Reason: Due to inactivity and merge conflict

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128873
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=698dbe322bb81421af3203779b456ca3940f1e7b
Submitter: Jenkins
Branch: master

commit 698dbe322bb81421af3203779b456ca3940f1e7b
Author: swati <email address hidden>
Date: Mon Feb 23 15:45:35 2015 +0530

    Confirm Dialog for Delete operation in Network Topology

    When we click a delete button in network topology, the corresponding
    delete operation is issued immediately. Now, a confirm dialog is
    displayed first to confirm the user's action and then the item gets
    deleted accordingly. It brings better consistency with delete
    operations of other tables.

    Change-Id: I1312364c75cea17f228eb298daacb141bf1bfdde
    Co-Authored-By: Vladislav Kuzmin <email address hidden>
    Co-Authored-By: Swati Sharma <email address hidden>
    Co-Authored-By: Allen <[e-mail]>
    Closes-Bug: #1242251

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0b3 development milestone.