compute.instance.delete.end notification emitted without deleted_at

[Andrew Melton]

The compute.instance.delete.end notification used to have a value for deleted_at. It seems that deleted_at is being set in the database, but the final notification for a deleted instance is emitted without it. It is important that the final notification for an instance be sent with up-to-date details as it is potentially the last notification that will be sent.

Sample Notification: http://paste.openstack.org/show/48702/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/52739

[Mark McLoughlin (markmc)]

https://review.openstack.org/52691

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/52691
Committed: http://github.com/openstack/nova/commit/0c409d98bb8f04bc1ba9a47d86c13678ab9221e5
Submitter: Jenkins
Branch: master

commit 0c409d98bb8f04bc1ba9a47d86c13678ab9221e5
Author: Andrew Melton <email address hidden>
Date: Tue Oct 29 11:08:30 2013 -0400

    Send delete.end with latest instance state

    Delete.end notifications were getting sent with a blank deleted_at
    field. This meant that services listening to notifications for
    instance state changes could potentially never get the instances
    deleted_at value. The instance usage audit notification would be
    the only source for that value.

    This change returns the destroyed instance from the conductor API
    and sends the delete.end notification with that state, containing
    the deleted_at value which was just set.

    UpgradeImpact
    Closes-Bug: #1241681
    Change-Id: I3481e0bada1711c3bff50f249f6a2b40a4ea6855