Do not use -Wall unconditionally
Bug #1241633 reported by
Dagobert Michelsen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| libmetalink |
Fix Released
|
Low
|
Tatsuhiro Tsujikawa | ||
Bug Description
-Wall is added unconditionally to AM_CFLAGS in lib/Makefile.am:
AM_CFLAGS = -Wall
and to AM_CPPFLAGS in doc/examples/
AM_CPPFLAGS = -Wall -I$(top_
This is bad as some compilers != GCC to not understand -Wall and adding the flag should either be tested or skipped at all.
As -Wall is also added when maintainer_mode is turned on in configure.ac it should generally not be necessary to add -Wall.
Revision history for this message
| Tatsuhiro Tsujikawa (t-tujikawa) wrote | #1 |
| Changed in libmetalink: | |
| assignee: | nobody → Tatsuhiro Tsujikawa (t-tujikawa) |
| importance: | Undecided → Low |
| milestone: | none → libmetalink-0.1.3 |
| status: | New → Fix Committed |
| Changed in libmetalink: | |
| milestone: | libmetalink-0.1.3 → none |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Sorry, for long long delay. Now fix committed via r156.