heat "Stack creation failed" error messages need improvement

[Tom Fifield]

When trying to launch a stack, there are several scenarios that results in a "Stack creation failed" error message

quick examples include:

 2013-10-18 18:40:17.931 11283 TRACE heat.openstack.common.rpc.amqp ValueError: db_password Password must start with an uppercase character
2013-10-18 18:40:17.931 11283 TRACE heat.openstack.common.rpc.amqp
2013-10-18 18:40:17.938 11283 ERROR heat.openstack.common.rpc.common [-] Returning exception db_password Password must start with an uppercase character to caller

2013-10-18 18:40:52.899 10922 TRACE root ValueError: db_password Password length must be between 6 and 8 characters

These should ideally be shown to the user in some way.

Note - this could be a heat problem, rather than one in horizon. I'll leave that to triage.

This is running Havana release from the ubuntu cloud archive.

[Tom Fifield (fifieldt)]

Verified by users on IRC.

[Tom Fifield (fifieldt)]

This is still an issue in icehouse release candidates.

[Tom Fifield (fifieldt)]

example from debug log that should be carried through to the dashboard

[Fri Apr 11 04:55:37.760404 2014] [:error] [pid 22351] HTTP/1.1 400 Bad Request
[Fri Apr 11 04:55:37.760408 2014] [:error] [pid 22351] date: Fri, 11 Apr 2014 04:55:37 GMT
[Fri Apr 11 04:55:37.760410 2014] [:error] [pid 22351] content-length: 301
[Fri Apr 11 04:55:37.760413 2014] [:error] [pid 22351] content-type: application/json; charset=UTF-8
[Fri Apr 11 04:55:37.760416 2014] [:error] [pid 22351]
[Fri Apr 11 04:55:37.760419 2014] [:error] [pid 22351] {"explanation": "Environment not in valid format: The environment is not a valid YAML mapping data type.", "code": 400, "error": {"message": "Environment not in valid format: The environment is not a valid YAML mapping data type.", "traceback": null, "type": "HTTPBadRequest"}, "title": "Bad Request"}
[Fri Apr 11 04:55:37.760422 2014] [:error] [pid 22351]
[Fri Apr 11 04:55:37.761751 2014] [:error] [pid 22351] Recoverable error: ERROR: Environment not in valid format: The environment is not a valid YAML mapping data type.

[Tom Fifield (fifieldt)]

All that is shown to the user is "Stack creation failed."

[Steven Hardy (shardy)]

So we need details of the various ways this can be reproduced. One way I've found is when you try to create a stack with a duplicate name.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/87138

[Tom Fifield (fifieldt)]

for the one above, create a stack with some random string in the environment box.

For the previous one, enter an invalid password (based on template policy - eg the wordpress template)

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/87138
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2c7db077b265c25573bfef73586a539fa639f65f
Submitter: Jenkins
Branch: master

commit 2c7db077b265c25573bfef73586a539fa639f65f
Author: Steve Baker <email address hidden>
Date: Mon Apr 14 09:15:37 2014 +1200

    Fix formatting of heat exceptions

    Heat now consistently formats error messages in returned HTTP json
    and heatclient HTTPException makes every attempt to capture these
    messages.

    This means that the safest way to display an error or validation
    message from Heat is to rely on the existing behaviour of
    Horizon's exceptions.handle.

    Change-Id: I80cdb67df87cb5192f220bc78a156d6e4113112f
    Closes-Bug: #1241395

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/100416

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100416
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a29cdbc48f65f8e9b648b8ab03a8a3bdd60663b9
Submitter: Jenkins
Branch: stable/icehouse

commit a29cdbc48f65f8e9b648b8ab03a8a3bdd60663b9
Author: Steve Baker <email address hidden>
Date: Mon Apr 14 09:15:37 2014 +1200

    Fix formatting of heat exceptions

    Heat now consistently formats error messages in returned HTTP json
    and heatclient HTTPException makes every attempt to capture these
    messages.

    This means that the safest way to display an error or validation
    message from Heat is to rely on the existing behaviour of
    Horizon's exceptions.handle.

    Change-Id: I80cdb67df87cb5192f220bc78a156d6e4113112f
    Closes-Bug: #1241395
    (cherry picked from commit 2c7db077b265c25573bfef73586a539fa639f65f)