when doing live migration, there are a lot of duplicate logic to release instance resource between driver destory and post live migration

Bug #1240820 reported by Yaguang Tang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Yaguang Tang

Bug Description

when doing live migration, there are a lot of duplicate logic to release instance resources between driver destroy and post live migration. instance migrated to destination
don't need a destroy in source Hypervisor, expose a cleanup api seems better to be used.

Yaguang Tang (heut2008)
Changed in nova:
assignee: nobody → Yaguang Tang (heut2008)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/52777

Changed in nova:
status: New → In Progress
Yaguang Tang (heut2008)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/52777
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5ffa65ada6adb7e3322ae88cc6ddb03998be08ac
Submitter: Jenkins
Branch: master

commit 5ffa65ada6adb7e3322ae88cc6ddb03998be08ac
Author: Yaguang Tang <email address hidden>
Date: Sat Oct 19 23:12:02 2013 +0800

    Optimize libvirt live migration workflow at source

    During live migration, after instance migrated to destination, we
    call Hypervisor destroy to clean the instance, this can be omitted
    because it doesn't exist in source server already. This patch changes
    cleanup to a public method to driver, split instance destroy to two
    step:

    1. destroy instance in the Hypervisor
    2. cleanup instance resources(block device, network)

    Change-Id: I65e711c03fee7342b1e2bc4f9459baae7729f911
    Closes-bug: 1240820

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.