should validate the parameters of agent API

[Ken'ichi Ohmichi]

The agent API has some parameters, but they are not validated.
Each parameter is stored to the table "agent_builds", and each column is defined as varchar(255).

mysql> desc agent_builds;
    +--------------+--------------+------+-----+---------+----------------+
    | Field | Type | Null | Key | Default | Extra |
    +--------------+--------------+------+-----+---------+----------------+
    | created_at | datetime | YES | | NULL | |
    | updated_at | datetime | YES | | NULL | |
    | deleted_at | datetime | YES | | NULL | |
    | id | int(11) | NO | PRI | NULL | auto_increment |
    | hypervisor | varchar(255) | YES | MUL | NULL | |
    | os | varchar(255) | YES | | NULL | |
    | architecture | varchar(255) | YES | | NULL | |
    | version | varchar(255) | YES | | NULL | |
    | url | varchar(255) | YES | | NULL | |
    | md5hash | varchar(255) | YES | | NULL | |
    | deleted | int(11) | YES | | NULL | |
    +--------------+--------------+------+-----+---------+----------------+

Due to this fact, if specifying very long characters as a parameter, the stored data is truncated like the following:

$ nova agent-create os arch 1 url hash 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
[..]
$
$ $ nova agent-list
+----------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----+--------------+---------+---------+-----+
| Agent_id | Hypervisor | OS | Architecture | Version | Md5hash | Url |
+----------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----+--------------+---------+---------+-----+
| 1 | 012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234 | os | arch | 1 | hash | url |
+----------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----+--------------+---------+---------+-----+
$

so the parameters should be validated before storing to DB.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/52054

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/52054
Committed: http://github.com/openstack/nova/commit/de7321d53fb4a2c01e5fbccbec1954c00ef363d6
Submitter: Jenkins
Branch: master

commit de7321d53fb4a2c01e5fbccbec1954c00ef363d6
Author: Ken'ichi Ohmichi <email address hidden>
Date: Wed Oct 16 19:29:22 2013 +0900

    Validate parameters of agent API

    The agent API has some parameters, but they are not validated.
    Each parameter is stored to the table "agent_builds", and each column
    is defined as varchar(255).

    mysql> desc agent_builds;
    +--------------+--------------+------+-----+---------+----------------+
    | Field | Type | Null | Key | Default | Extra |
    +--------------+--------------+------+-----+---------+----------------+
    | created_at | datetime | YES | | NULL | |
    | updated_at | datetime | YES | | NULL | |
    | deleted_at | datetime | YES | | NULL | |
    | id | int(11) | NO | PRI | NULL | auto_increment |
    | hypervisor | varchar(255) | YES | MUL | NULL | |
    | os | varchar(255) | YES | | NULL | |
    | architecture | varchar(255) | YES | | NULL | |
    | version | varchar(255) | YES | | NULL | |
    | url | varchar(255) | YES | | NULL | |
    | md5hash | varchar(255) | YES | | NULL | |
    | deleted | int(11) | YES | | NULL | |
    +--------------+--------------+------+-----+---------+----------------+

    This patch adds the validation with the type and the length.

    Closes-Bug: 1240458

    Change-Id: Id06235ebde62f7b96c55b0bd2be5d941bfd2e999