v3 server controller load update extension point without checking right require function

Bug #1240351 reported by Alex Xu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Alex Xu

Bug Description

server's controller load the update extension point as below:

       # Look for implmentation of extension point of server update
        self.update_extension_manager = \
            stevedore.enabled.EnabledExtensionManager(
                namespace=self.EXTENSION_UPDATE_NAMESPACE,
                check_func=_check_load_extension('server_resize'),
                invoke_on_load=True,
                invoke_kwds={"extension_info": self.extension_info},
                propagate_map_exceptions=True)
        if not list(self.update_extension_manager):

But it's checking function with wrong params, it should be _check_load_extension('server_update').

Alex Xu (xuhj)
Changed in nova:
assignee: nobody → Alex Xu (xuhj)
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/52014

Changed in nova:
status: Triaged → In Progress
Alex Xu (xuhj)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/52014
Committed: http://github.com/openstack/nova/commit/edcc7dcbcbfa50a002767d437ea9cf344d1d7a37
Submitter: Jenkins
Branch: master

commit edcc7dcbcbfa50a002767d437ea9cf344d1d7a37
Author: He Jie Xu <email address hidden>
Date: Wed Oct 16 13:56:03 2013 +0800

    Correct update extension point's check_func for v3 server's controller

    When loading update extension point, it should check the extension has
    'server_update' function. But current code check with wrong function
    name 'server_resize'. And this patch adds testcase for servers extension
    point.

    Change-Id: I2bee7ff306b3337d24047e471fac9485fec9a6f7
    Closes-bug: #1240351

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.