API cell always doing local deletes

[Chris Behrens]

It appears a regression was introduced in:

https://review.openstack.org/#/c/36363/

Where the API cell is now always doing a _local_delete()... before telling child cells to delete the instance. There's at least a couple of bad side effects of this:

1) The instance disappears immediately from API view, even though the instance still exists in the child cell. The user does not see a 'deleting' task state. And if the delete fails in the child cell, you have a sync issue until the instance is 'healed'.
2) Double delete.start and delete.end notifications are sent. 1 from API cell, 1 from child cell.

The problem seems to be that _local_delete is being called because the service is determined to be down... because the compute service does not run in the API cell.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51948
Committed: http://github.com/openstack/nova/commit/0493c803ae9612f87ed028e1a39e880aead5bdcb
Submitter: Jenkins
Branch: master

commit 0493c803ae9612f87ed028e1a39e880aead5bdcb
Author: Chris Behrens <email address hidden>
Date: Tue Oct 15 21:48:54 2013 +0000

    Cells: Fix instance deletes

    A regression was introduced with object conversion that caused all
    instances to be locally deleted in the API cell when cells is enabled.
    This would happen before the child cell was told to delete the instance.

    Additionally, if an instance record was created in a child cell but
    failed to schedule to a host in such a way that the API cell has
    no knowledge of the 'host', the instance would be deleted in the API
    cell only.

    Also, it appears that we would cast deletes to child cells twice due to
    logic duplicated in cells_api.py that exists in api.py.

    Closes-Bug: #1240247

    Change-Id: I94cfddd9cef2d63b2cb31c0f2dae8e211a4418d9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/54443

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54443
Committed: http://github.com/openstack/nova/commit/54fa794e67a93a823fbd772ae8ef5b4d96d4bb5f
Submitter: Jenkins
Branch: stable/havana

commit 54fa794e67a93a823fbd772ae8ef5b4d96d4bb5f
Author: Chris Behrens <email address hidden>
Date: Tue Oct 15 21:48:54 2013 +0000

    Cells: Fix instance deletes

    A regression was introduced with object conversion that caused all
    instances to be locally deleted in the API cell when cells is enabled.
    This would happen before the child cell was told to delete the instance.

    Additionally, if an instance record was created in a child cell but
    failed to schedule to a host in such a way that the API cell has
    no knowledge of the 'host', the instance would be deleted in the API
    cell only.

    Also, it appears that we would cast deletes to child cells twice due to
    logic duplicated in cells_api.py that exists in api.py.

    Closes-Bug: #1240247

    Change-Id: I94cfddd9cef2d63b2cb31c0f2dae8e211a4418d9
    (cherry picked from commit 0493c803ae9612f87ed028e1a39e880aead5bdcb)