boto version checking in test cases still not correct
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Stanislaw Pitucha |
Bug Description
https:/
boto_version = pkg_resources.
if boto_version >= (2, 13):
self.
elif boto_version >= (2,):
self.
else:
self.
However, this is still not correct:
>>> import pkg_resources
>>> import boto
>>> print boto.Version
2.9.6
>>> boto_version = pkg_resources.
>>> print boto_version
('00000002', '00000009', '00000006', '*final')
>>> print boto_version >= (2, 13)
I believe we should also be using pkg_resources to construct the other side of the conditional:
>>> print boto_version >= pkg_resources.
False
tags: | added: grizzly-backport-potential havana-backport-potential |
tags: | removed: grizzly-backport-potential havana-backport-potential |
Changed in nova: | |
milestone: | none → icehouse-1 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
assignee: | Adam Gandelman (gandelman-a) → Stanislaw Pitucha (stanislaw-pitucha) |
Changed in nova: | |
milestone: | icehouse-1 → 2014.1 |
review is here - https:/ /review. openstack. org/#/c/ 51757/