urlparse imported directly breaking python 3

Bug #1239802 reported by Clint Byrum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
Clint Byrum

Bug Description

urlparse should be imported indirectly using the six library to avoid breaking python3 users of keystoneclient.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/51685

Changed in python-keystoneclient:
assignee: nobody → Clint Byrum (clint-fewbar)
status: New → In Progress
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/51685
Committed: http://github.com/openstack/python-keystoneclient/commit/43e278c8be05a25edd17729ee2ab3de2be8044fe
Submitter: Jenkins
Branch: master

commit 43e278c8be05a25edd17729ee2ab3de2be8044fe
Author: Clint Byrum <email address hidden>
Date: Mon Oct 14 11:16:42 2013 -0700

    Fix python3 incompatible use of urlparse

    Use six to make it work. While we're not yet able to gate
    keystoneclient on py33, we still need keystoneclient to work when
    keystoneclient is included in other libraries' test suites. This was
    discovered while working on python3 for python-tuskarclient.

    Note that together with I65c28896d1551fd537dd7774e87bc479a477a7ab
    keystoneclient can be used safely in python-tuskarclient's py33 tests.

    Closes-bug: #1239802

    Change-Id: Ie6d31dc5fae7e63bb31a5192fa6765fe35dd026a

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.4.2
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.