NovaObject does not properly honor VERSION

[Dan Smith]

The base object infrastructure has been comparing Object.version instead of the Object.VERSION that *all* the objects have been setting and incrementing when changes have been made. Since the base object defined a .version, and that was used to determine the actual version of an object, all objects defining a different VERSION were ignored.

All systems in the wild currently running broken code are sending version '1.0' for all of their objects. The fix is to change the base object infrastructure to properly examine, compare and send Object.VERSION.

Impact should be minimal at this point, but getting systems patched as soon as possible will be important going forward.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/51615

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51615
Committed: http://github.com/openstack/nova/commit/99cbfb3492c80ded53fa018fe5a0881f977dc407
Submitter: Jenkins
Branch: master

commit 99cbfb3492c80ded53fa018fe5a0881f977dc407
Author: Dan Smith <email address hidden>
Date: Mon Oct 14 07:01:01 2013 -0700

    Fix NovaObject versioning attribute usage

    A typo made early in the object prototyping process has meant that
    all objects thus far have been exposing a version of '1.0' because
    the base object has been using an attribute of 'version'. The
    object implementations have been exposing a 'VERSION' attribute
    with their desired version advertisement.

    Since we are still relatively early in the process of deploying
    objects, the impact from this should be relatively minor, although
    it is important to get this fixed ASAP before any incompatible
    object changes are made.

    Change-Id: If9154dc663111f304f72ef7f6f37c465e84ff504
    Closes-bug: #1239709

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/52450

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/52450
Committed: http://github.com/openstack/nova/commit/e76a123a9e1d4ab10864ba523d79c3e559687991
Submitter: Jenkins
Branch: stable/havana

commit e76a123a9e1d4ab10864ba523d79c3e559687991
Author: Dan Smith <email address hidden>
Date: Mon Oct 14 07:01:01 2013 -0700

    Fix NovaObject versioning attribute usage

    A typo made early in the object prototyping process has meant that
    all objects thus far have been exposing a version of '1.0' because
    the base object has been using an attribute of 'version'. The
    object implementations have been exposing a 'VERSION' attribute
    with their desired version advertisement.

    Since we are still relatively early in the process of deploying
    objects, the impact from this should be relatively minor, although
    it is important to get this fixed ASAP before any incompatible
    object changes are made.

    (cherry picked from commit 99cbfb3492c80ded53fa018fe5a0881f977dc407)

    Change-Id: If9154dc663111f304f72ef7f6f37c465e84ff504
    Closes-bug: #1239709