The lockutils synchronised decorator does not log lock released message

Bug #1239679 reported by Paul Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Paul Murray

Bug Description

The synchronised decorator method logs a message to indicate that a semaphore / lock has been claimed, but does not log a message to say it has been released. The log message is there in the code but it is in unreachable code, due to the wrapped function being returned.

Example claim message:
2013-09-16 20:38:00.844 DEBUG nova.openstack.common.lockutils [-] Got semaphore / lock "update_available_resource" from (pid=19079) inner /opt/stack/nova/nova/openstack/common/lockutils.py:246

The missing release message should be:
2013-09-16 20:38:01.085 DEBUG nova.openstack.common.lockutils [-] Semaphore / lock released "update_available_resource" from (pid=19079) inner /opt/stack/nova/nova/openstack/common/lockutils.py:251

Paul Murray (pmurray)
Changed in nova:
assignee: nobody → Paul Murray (pmurray)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/51601

Changed in nova:
status: New → In Progress
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Need to get this into Oslo-incubator first
https://review.openstack.org/#/c/49969/

Revision history for this message
Paul Murray (pmurray) wrote :
Changed in nova:
status: In Progress → Fix Released
Thierry Carrez (ttx)
Changed in nova:
status: Fix Released → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.