Bogus ERROR level debug spew when creating a new instance

Bug #1239603 reported by Matthew Macdonald-Wallace (HPCS)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Matthew Macdonald-Wallace (HPCS)
Havana
Fix Released
High
Gary Kotton

Bug Description

Change-Id: Ifd41886b9bc7dff01cdf741a833946bed1bdddc implemented a number of items required for auto_disk_config to be more than just "True" or "False".

It appears that a logging statement used for debugging of the code has been left behind:

1256 def _check_auto_disk_config(self, instance=None, image=None,
1257 **extra_instance_updates):
1258 auto_disk_config = extra_instance_updates.get("auto_disk_config")
1259 if auto_disk_config is None:
1260 return
1261 if not image and not instance:
1262 return
1263
1264 if image:
1265 image_props = image.get("properties", {})
1266 LOG.error(image_props)

This needs to be removed as it is causing false-positives to be picked up by our error-tracking software

Changed in nova:
assignee: nobody → Matthew Macdonald-Wallace (HPCS) (matthew-macdonald-wallace)
Revision history for this message
Mark McLoughlin (markmc) wrote :
Changed in nova:
importance: Undecided → High
summary: - api.py sends an error with image properties when creating a new instance
+ Bogus ERROR level debug spew when creating a new instance
Changed in nova:
status: New → In Progress
tags: added: havana-rc-potential
Thierry Carrez (ttx)
tags: added: havana-backport-potential
removed: havana-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/51563
Committed: http://github.com/openstack/nova/commit/7ef98b44374945cd157b125a9b46ee5727d285fe
Submitter: Jenkins
Branch: master

commit 7ef98b44374945cd157b125a9b46ee5727d285fe
Author: Matthew Macdonald-Wallace <email address hidden>
Date: Mon Oct 14 11:11:07 2013 +0100

    Remove unnecessary "LOG.error()" statement

    Removes apparent debug statement left in from
    Ifd41886b9bc7dff01cdf741a833946bed1bdddc

    Fixes-Bug: #1239603
    Change-Id: I9c5b9a6b2349a6c62bef2974ab3b0bb986533741

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/53597

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/53597
Committed: http://github.com/openstack/nova/commit/a582ed15e71f1dc3643c1c5667a381a249d3f771
Submitter: Jenkins
Branch: stable/havana

commit a582ed15e71f1dc3643c1c5667a381a249d3f771
Author: Matthew Macdonald-Wallace <email address hidden>
Date: Mon Oct 14 11:11:07 2013 +0100

    Remove unnecessary "LOG.error()" statement

    Removes apparent debug statement left in from
    Ifd41886b9bc7dff01cdf741a833946bed1bdddc

    Closes-Bug: #1239603
    Change-Id: I9c5b9a6b2349a6c62bef2974ab3b0bb986533741
    (cherry picked from commit 7ef98b44374945cd157b125a9b46ee5727d285fe)

tags: added: in-stable-havana
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: havana-backport-potential in-stable-havana
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.