--upload-tools failure preventing bootstrap completing

Bug #1239558 reported by Julian Edwards
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Go MAAS API Library
Fix Released
Critical
Ian Booth
Go OpenStack Exchange
Fix Released
Critical
Ian Booth
Go Windows Azure Client Library
Fix Released
Critical
Ian Booth
juju-core
Fix Released
Critical
Ian Booth

Bug Description

Related branches

Revision history for this message
Ian Booth (wallyworld) wrote :

So, it turns out that the gomaasapi client needs to set Close=true on the http.Request structs that are created. This wasn't necessary before. Perhaps it's a Go 1.1.2 issue. NFI.

Changed in juju-core:
assignee: nobody → Ian Booth (wallyworld)
importance: Undecided → Critical
status: New → Triaged
Changed in gomaasapi:
importance: Undecided → Critical
status: New → Triaged
assignee: nobody → Ian Booth (wallyworld)
no longer affects: juju-core
Revision history for this message
Ian Booth (wallyworld) wrote :

So this is caused by a bug in Go's http lib not dealing with transport failures properly.
https://code.google.com/p/go/issues/detail?id=4677

But it's marked as not fixed for Go 1.2. So we are on our own. One option is to set the Close attribute on each Request struct to true, but this has the unfortunate side effect of killing any connection re-use :-(

Ian Booth (wallyworld)
Changed in goose:
importance: Undecided → Critical
assignee: nobody → Ian Booth (wallyworld)
status: New → Triaged
Ian Booth (wallyworld)
Changed in gwacl:
importance: Undecided → Critical
status: New → Triaged
assignee: nobody → Ian Booth (wallyworld)
Revision history for this message
Ian Booth (wallyworld) wrote :

The root cause problem affects any Go project which uses the standard Go http library. So juju-core and related deoendencies need to be hacked to work around the issue.

Changed in juju-core:
assignee: nobody → Ian Booth (wallyworld)
importance: Undecided → Critical
status: New → Triaged
Ian Booth (wallyworld)
Changed in gomaasapi:
status: Triaged → Fix Committed
Changed in juju-core:
milestone: none → 1.17.0
Changed in goose:
status: Triaged → Fix Committed
Changed in gwacl:
status: Triaged → Fix Committed
Changed in juju-core:
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
tags: added: golang sync-tools upgrade-juju
tags: added: upload-tools
removed: upgrade-juju
Curtis Hovey (sinzui)
Changed in goose:
status: Fix Committed → Fix Released
Changed in gomaasapi:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in gwacl:
milestone: none → 0.1.1
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.