Add keyboard shortcuts to focus current page and scale factor tool bar elements

Bug #1239054 reported by Ari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qpdfview
Fix Released
Wishlist
Adam Reichold

Bug Description

## Description

The "jump-to-page" feature is a boon to keyboard users but in its current implementation I feel that it is redundant to the page counter.

## Proposal

Instead of having a separate page jump dialog it might be a good idea to simply implement a shortcut to focus the currentPage toolbar element. Given how <Ctrl>+<L> switches focus to the location bar in web browsers and file managers this might be a good choice for the default shortcut assignment. Keeping the Jump hotkey would work as well, of course.

Related branches

Revision history for this message
Adam Reichold (adamreichold) wrote :

Hello Ari,

the jump to page dialog is indeed redundant with the tool bar entry as it was specifically requested by people using qpdfview without the tool bars. :-) But I do see the usefulness of adding keyboard shortcuts to focus the two important tool bar elements "currentPage" and "scaleFactor", so I'll try adding those. (Have to think of a sensible default though...)

Best regards, Adam.

Changed in qpdfview:
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → Adam Reichold (adamreichold)
milestone: none → 0.4.7
summary: - Replace "jump to page" dialog with keyboard shortcut that focuses the
- currentPage element
+ Add keyboard shortcuts to focus current page and scale factor tool bar
+ elements
Revision history for this message
Adam Reichold (adamreichold) wrote :

Ok, you can try this out using the linked branch where Ctrl+K will focus current page and Ctrl+L will focus scale factor. (They are not configurable in the shortcut settings as with the tab shortcuts, only real actions with a name are.)

Revision history for this message
Ari (ari-lp) wrote :

Hi Adam,

thanks for getting back to me so quickly.

> the jump to page dialog is indeed redundant with the tool bar entry as it was specifically requested by people using qpdfview without the tool bars.

Ah, I see. I didn't even consider that use case. It's always interesting to see how other people customize their applications. It goes to show how adaptable qpdfview is :) !

> Ok, you can try this out using the linked branch where Ctrl+K will focus current page and Ctrl+L will focus scale factor.

Working fine here. Thanks again for the prompt implementation!

Cheers
-- Ari

Changed in qpdfview:
status: In Progress → Fix Committed
Changed in qpdfview:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.