API lacks get-node-by-instance-uuid

Bug #1239026 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Ling Gao
python-ironicclient
Fix Released
High
Ling Gao

Bug Description

The API needs to expose a means to search for a node, given an instance UUID.

aeva black (tenbrae)
Changed in python-ironicclient:
status: New → Triaged
importance: Undecided → High
Changed in ironic:
status: New → Triaged
importance: Undecided → High
Ling Gao (linggao)
Changed in ironic:
assignee: nobody → Ling Gao (linggao)
Changed in python-ironicclient:
assignee: nobody → Ling Gao (linggao)
Revision history for this message
Ling Gao (linggao) wrote :

Can you give more details? The following works already for ironic-api:
http://<ip>/nodes/<uuid>

Revision history for this message
aeva black (tenbrae) wrote :

@linggao,

The API exposes GET /nodes/<node-uuid> today. What we need is a means to search for a node, given the Nova instance UUID which is stored in the ironic.nodes table in the "instance_uuid" column.

More specifically, we need three functions exposed:

- get the node with a specific instance_uuid
- get all nodes with instance_uuid == NULL
- get all nodes with instance_uuid != NULL

The URL should look something like this:

GET /v1/nodes?instance_uuid=<value>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53262

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53485

Changed in python-ironicclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/53262
Committed: http://github.com/openstack/ironic/commit/a44eed7751f51797b7c0aae1dd1855c5d1b268f0
Submitter: Jenkins
Branch: master

commit a44eed7751f51797b7c0aae1dd1855c5d1b268f0
Author: linggao <email address hidden>
Date: Wed Oct 23 02:45:52 2013 +0000

    Supports get node by instance uuid in API

    The API needs to expose a means to search for a node, given an
    instance uuid. This patch supports getting a node by an instance
    uuid (/nodes?instance_uuid=<xxx>), getting all the nodes that have
    instance uuid associated (/nodes?associated=True)
    and getting all the nodes that do not have such associations
    (/nodes?associated=False).

    Change-Id: I40750f9a7fc91e87223bfcd72e17e25f4045359c
    Partial-Bug: #1239026

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/53485
Committed: http://github.com/openstack/python-ironicclient/commit/f5823b20bc4e78dac3a93c99c4e114588e210588
Submitter: Jenkins
Branch: master

commit f5823b20bc4e78dac3a93c99c4e114588e210588
Author: linggao <email address hidden>
Date: Thu Oct 24 01:09:49 2013 +0000

    Modifies CLI to show nodes by instance uuid

    This patch updates the node-show subcommand for ironic so that it
    shows the node that matches the given instance UUID.
    ironic node-show [--instance] id
    It also updates node-list subcommand so that it can show all the
    nodes that have instance UUID associated or the opposite.
    ironic node-list [--associated true|false]
    This patch also fixes a few strings for i18n support.

    Change-Id: I2aec9ba6e296e0d1db9f3ef9eed7236ecfb32cf6
    Closes-Bug: #1239026

Changed in python-ironicclient:
status: In Progress → Fix Committed
Ling Gao (linggao)
Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-1 → 2014.1
Changed in python-ironicclient:
milestone: none → 0.7.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.