scheduler filter disk_filter doesn't take swap into account

Bug #1239009 reported by Joe Gordon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Joe Gordon

Bug Description

from nova/scheduler/filters/disk_filter.py

    def host_passes(self, host_state, filter_properties):
        """Filter based on disk usage."""
        instance_type = filter_properties.get('instance_type')
        requested_disk = 1024 * (instance_type['root_gb'] +
                                 instance_type['ephemeral_gb'])

This should take into account swap, which is stored in MB, as well.

Joe Gordon (jogo)
Changed in nova:
assignee: nobody → Joe Gordon (jogo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/51323

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/51323
Committed: http://github.com/openstack/nova/commit/e842fff31fd77289507d89387a62eee288aea6bc
Submitter: Jenkins
Branch: master

commit e842fff31fd77289507d89387a62eee288aea6bc
Author: Joe Gordon <email address hidden>
Date: Fri Oct 11 17:06:33 2013 -0700

    Make scheduler disk_filter take swap into account

    The disk_filter, which makes sure a node has enough disk space for an
    instance doesn't take the swap partition into account, but swap takes up
    disk space so it should.

    Change-Id: I0779dcf0f1cd60017b5b49ca38c0a15b23d802d7
    Closes-Bug: #1239009

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.