baremetal allows to register an interface having an empty mac address

[Arata Notsu]

It leads a network manager to create an invalid entry in dnsmasq's hostsfile, like:

,bm.novalocal,10.0.0.2
(The first column is a mac address. In this case, the instance never receive 10.0.0.2)

In addition, once such a interface is added, we cannot delete it.

    $ nova baremetal-interface-remove 1 ''
    ERROR: Must specify id or address (HTTP 400) (Request-ID: req-d0631fc4-361d-43fa-870a-82e077cd454b)

[Arata Notsu (arata776)]

https://review.openstack.org/51202/

[aeva black (tenbrae)]

I believe this does not affect Ironic, as there is validation of MAC addresses done within the db/api layer, which was not done by Nova.

I will re-open if it is demonstrated that one can create an invalid or empty mac address in Ironic, leading to similar failures.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51202
Committed: http://github.com/openstack/nova/commit/d3524fb5015ea493f1997dc94589907bdff8f8eb
Submitter: Jenkins
Branch: master

commit d3524fb5015ea493f1997dc94589907bdff8f8eb
Author: Arata Notsu <email address hidden>
Date: Thu Nov 14 17:57:28 2013 +0900

    baremetal: Make api validate mac address

    Check if the address in the form of xx:xx:xx:xx:xx:xx.

    Closes-Bug: 1238595
    Change-Id: Idcba745a011604d7664b62d88f1dede88d10443d