Theme: site-logo image is ignored

[Ghada El-Zoghbi]

Mahara: 1.8rc2dev
DB: Postgres or MySql
Op System: Linux
browser: Firefox 24.0

If a new theme is created with the following structure (i.e. only a site-logo.png and themeconfig.php)

/htdocs/theme/test/static/images/site-logo.png
/htdocs/theme/test/themeconfig.php

with the following in themeconfig.php:
$theme = new StdClass;
$theme->displayname = 'test';
$theme->parent = 'default';

When the 'test' theme is selected in site options, the site-logo.png is ignored. The default Mahara site logo is displayed instead.

[Aaron Wells (u-aaronw)]

Hi Ghada,

Thanks for the bug report! I think you're right, according to the documentation ( https://wiki.mahara.org/index.php/Customising/Themes ) the bare minimum you should need for a theme is a themeconfig.php file that specifies the theme's parent, which you have provided.

Do you know if this bug is present in 1.7 and earlier as well, or is it a regression in 1.8?

Cheers,
Aaron

[Ghada El-Zoghbi (ghada-z)]

Hi Aaron,

This only started happening with the latest pull from master.

I had pulled the latest on Friday last week (Oct 4) and it was fine.
This issue was not present.

Then, I did another pull on Wednesday this week (Oct 9) and that's when
it started happening.

Cheers,
Ghada

On 11/10/13 11:13, Aaron Wells wrote:
> Hi Ghada,
>
> Thanks for the bug report! I think you're right, according to the
> documentation ( https://wiki.mahara.org/index.php/Customising/Themes )
> the bare minimum you should need for a theme is a themeconfig.php file
> that specifies the theme's parent, which you have provided.
>
> Do you know if this bug is present in 1.7 and earlier as well, or is it
> a regression in 1.8?
>
> Cheers,
> Aaron
>
> ** Changed in: mahara
> Status: New => Triaged
>
> ** Changed in: mahara
> Importance: Undecided => High
>
> ** Changed in: mahara
> Milestone: None => 1.8.0
>
> ** Changed in: mahara
> Assignee: (unassigned) => Son Nguyen (ngson2000)
>

--
Ghada El-Zoghbi
Catalyst IT
<email address hidden>
tel:[phone]
www.catalyst-au.net

CONFIDENTIALITY NOTICE: This email is intended for the named recipients only. It may contain privileged, confidential or copyright information. If you are not the named recipients, any use, reliance upon, disclosure or copying of this email or any attachments is unauthorised. If you have received this email in error, please reply via email or telephone [phone].

[Aaron Wells (u-aaronw)]

Thanks, I'll tag it as a regression.

[Robert Lyon (robertl-9)]

Hmm, strange.

I followed the instructions:

If a new theme is created with the following structure (i.e. only a site-logo.png and themeconfig.php)

/htdocs/theme/test/static/images/site-logo.png
/htdocs/theme/test/themeconfig.php

with the following in themeconfig.php:
$theme = new StdClass;
$theme->displayname = 'test';
$theme->parent = 'default';

And when I set my theme to the 'test' one I see the 'test' site logo - as expected.
I also made another new theme 'test2' with another new site-logo.png image and used 'raw' as parent - it also showed me the correct logo image.

I'm unable to replicate the problem - though I did note than when i went to look at site in another browser I needed to do a hard refresh to get new logo to show (as I'd been to the site before new logo was in place).

[Ghada El-Zoghbi (ghada-z)]

Hi Robert,

With the latest merge of the code, it has started working again.

When I raised the bug, a hard refresh didn't display the new logo.

Maybe someone inadvertently fixed the bug.