with lvm_type=thin parsing of lvm version fails

Bug #1237994 reported by Giulio Fidente
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Giulio Fidente

Bug Description

supports_thin_provisioning fails on customised builds; RHEL for instance reports version as:

2.02.100(2)-RHEL6

2013-10-10 14:58:56.928 32460 TRACE cinder.service File "/usr/lib/python2.6/site-packages/cinder/brick/local_dev/lvm.py", line 142, in supports_thin_provisioning
2013-10-10 14:58:56.928 32460 TRACE cinder.service version_tuple = tuple(map(int, version.split('.')))
2013-10-10 14:58:56.928 32460 TRACE cinder.service ValueError: invalid literal for int() with base 10: '100-RHEL6'

Changed in cinder:
assignee: nobody → Giulio Fidente (gfidente)
Changed in cinder:
status: New → In Progress
summary: - parsing of lvm version fails
+ with lvm_type=thin parsing of lvm version fails
Eric Harney (eharney)
tags: added: havana-rc-potential
Changed in cinder:
milestone: none → havana-rc2
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/50919
Committed: http://github.com/openstack/cinder/commit/51fd5edb106e26d65696ce37a70eef6a4f75b1e2
Submitter: Jenkins
Branch: master

commit 51fd5edb106e26d65696ce37a70eef6a4f75b1e2
Author: Giulio Fidente <email address hidden>
Date: Thu Oct 10 14:59:44 2013 +0200

    improves lvm version parsing for customised builds

    supports_thin_provisioning now uses a regexp to ensure parsing of
    lvm version succeeds when the build is customised; also adds a test
    for a customised string parsing

    Closes-Bug: #1237994
    Change-Id: I49049a58bbdb5315b9d2d7c259a9324ca15d78cb

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/50987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/50987
Committed: http://github.com/openstack/cinder/commit/de031813b90d4a29fc6011a53fefa6c19001022e
Submitter: Jenkins
Branch: milestone-proposed

commit de031813b90d4a29fc6011a53fefa6c19001022e
Author: Giulio Fidente <email address hidden>
Date: Thu Oct 10 14:59:44 2013 +0200

    improves lvm version parsing for customised builds

    supports_thin_provisioning now uses a regexp to ensure parsing of
    lvm version succeeds when the build is customised; also adds a test
    for a customised string parsing

    Closes-Bug: #1237994
    Change-Id: I49049a58bbdb5315b9d2d7c259a9324ca15d78cb
    (cherry picked from commit 51fd5edb106e26d65696ce37a70eef6a4f75b1e2)

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.