nova services don't diagnose address already in use details

[Pádraig Brady]

There is no mention of port number in the very common case where the port is already in use.
You will just get a trace like:

CRITICAL nova [-] [Errno 98] Address already in use
TRACE nova Traceback (most recent call last):
TRACE nova File "/usr/bin/nova-api-metadata", line 10, in <module>
TRACE nova sys.exit(main())
TRACE nova File "/usr/lib/python2.6/site-packages/nova/cmd/api_metadata.py", line 33, in main
TRACE nova server = service.WSGIService('metadata')
TRACE nova File "/usr/lib/python2.6/site-packages/nova/service.py", line 318, in __init__
TRACE nova max_url_len=max_url_len)
TRACE nova File "/usr/lib/python2.6/site-packages/nova/wsgi.py", line 123, in __init__
TRACE nova self._socket = eventlet.listen(bind_addr, family, backlog=backlog)
TRACE nova File "/usr/lib/python2.6/site-packages/eventlet/convenience.py", line 38, in listen
TRACE nova sock.bind(addr)
TRACE nova File "<string>", line 1, in bind
TRACE nova error: [Errno 98] Address already in use

[Pádraig Brady (p-draigbrady)]

https://review.openstack.org/#/c/50914/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/50914
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c9d212a1083dcace36c6c7b0e2bbd6ad4274b0eb
Submitter: Jenkins
Branch: master

commit c9d212a1083dcace36c6c7b0e2bbd6ad4274b0eb
Author: Pádraig Brady <email address hidden>
Date: Thu Oct 10 13:09:35 2013 +0100

    report port number for address already in use errors

    * nova/wsgi.py(Service.__init__): Catch external errors
    (socket.error is a subclass of EnvironmentError since python 2.6),
    and log the port number attempted to bind to.

    Closes-Bug: 1237961
    Change-Id: Ia4eb46c76db855fc3168c5b7a233ce94d2ef7726