Cannot update IPSec Policy lifetime

[Tatiana Ovchinnikova]

When you try to update IPSec Policy lifetime, you get an error:

(neutron) vpn-ipsecpolicy-update ipsecpolicy --lifetime units=seconds,value=36001
Request Failed: internal server error while processing your request.

Meanwhile updating IKE Policy lifetime works well:

(neutron) vpn-ikepolicy-update ikepolicy --lifetime units=seconds,value=36001
Updated ikepolicy: ikepolicy

[Eugene Nikanorov (enikanorov)]

There's a problem with the next piece of code:

def update_ipsecpolicy(self, context, ipsecpolicy_id, ipsecpolicy):
       ...
         if ipsecp:
                lifetime_info = ipsecp.get('lifetime')
                if lifetime_info:
                    if lifetime_info.get('units'):
                        ipsecp['lifetime_units'] = lifetime_info['units']
                    if lifetime_info('value'):
                        ipsecp['lifetime_value'] = lifetime_info['value']
                ipsecp_db.update(ipsecp)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/50895

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/50895
Committed: http://github.com/openstack/neutron/commit/48e36b542904effb9b35c9d62bd0247e25f0dac6
Submitter: Jenkins
Branch: master

commit 48e36b542904effb9b35c9d62bd0247e25f0dac6
Author: Eugene Nikanorov <email address hidden>
Date: Thu Oct 10 13:10:58 2013 +0400

    Fix access to lifetime dict in update_ipsecpolicy method

    Also add corresponding unit test.

    Change-Id: Ie1141b5034415ccf3039a71dfedc47cfb2ca7a88
    Closes-Bug: #1237912

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/53255

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/53255
Committed: http://github.com/openstack/neutron/commit/2c41cf1cfc474be0bfb08d3e0bda92d67ac7b12a
Submitter: Jenkins
Branch: stable/havana

commit 2c41cf1cfc474be0bfb08d3e0bda92d67ac7b12a
Author: Eugene Nikanorov <email address hidden>
Date: Thu Oct 10 13:10:58 2013 +0400

    Fix access to lifetime dict in update_ipsecpolicy method

    Also add corresponding unit test.

    Change-Id: Ie1141b5034415ccf3039a71dfedc47cfb2ca7a88
    Closes-Bug: #1237912
    (cherry picked from commit 48e36b542904effb9b35c9d62bd0247e25f0dac6)