IPMI power manager hangs when the password is empty.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Invalid
|
Undecided
|
Unassigned | ||
OpenStack Compute (nova) |
Fix Released
|
High
|
Ryota Mibu |
Bug Description
While creating Baremetal Node by `nova baremetal-
This is an uncommon case that an administrator set password empty, but this is not a low importance bug due to it stops the thread.
I think we can avoid this bug by writing '\0' into the password file [3], since ipmitool checks return value of fgets() is not NULL which means the file is not start with EOF and no error had occurred.
[1] e.g.:
$ nova baremetal-
[2] In ipmitool manpage:
-f <password_file>
Specifies a file containing the remote server password. If this option is absent, or if password_file is empty, the password will default to NULL.
[3] I checked that ipmitool works with a file containing '\0';
# touch a
# ipmitool -I lanplus -H 192.0.2.94 -f a -U administrator power status
Unable to read password from file a
Unable to read password from file a
Password: <-- Enter
Chassis Power is off
# echo -ne '\0' > b
# ipmitool -I lanplus -H 192.0.2.94 -f b -U administrator power status
Chassis Power is off
summary: |
- IPMI power manager hangs up when the password is empty. + IPMI power manager hangs when the password is empty. |
description: | updated |
Changed in nova: | |
assignee: | nobody → Ryota Mibu (r-mibu) |
Changed in ironic: | |
status: | New → Opinion |
Changed in nova: | |
milestone: | none → icehouse-1 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-1 → 2014.1 |
That approach, while terrible, seems plausible ;). Want to send in a patch?