VMware: restarting nova compute reports invalid instances

[Gary Kotton]

When nova compute restarts the running instances on the hypervisor are queried. None of the instances would be matched - this would prevent the instance states being in sync with the state in the database. See _destroy_evacuated_instances (https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L531)

[Gary Kotton (garyk)]

https://review.openstack.org/#/c/50841/

[Sabari Murugesan (smurugesan)]

Wouldn't the brute force search kick-in if the method is not implemented by the virt driver. I know it's better to implement it, just curious if it really breaks anything :)

[Gary Kotton (garyk)]

The brute force does not kick in as it is with instance names and not UUID's.
For some reason gerrit did not link https://review.openstack.org/#/c/50841/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/50841
Committed: http://github.com/openstack/nova/commit/74289aacb5363bd72b449580325a651117e5342d
Submitter: Jenkins
Branch: master

commit 74289aacb5363bd72b449580325a651117e5342d
Author: Gary Kotton <email address hidden>
Date: Wed Oct 9 23:35:12 2013 -0700

    VMware: fix bug for reporting instance UUID's

    Ensure that the correct UUID's are reported to the compute
    manager. The fix will return only valid UUID's and not all
    of the names of the instances running.

    Closes-Bug: #1237795

    Change-Id: I32bb6f4783dcc80697abebd5a7f45ef9950a0896

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/54701

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54701
Committed: http://github.com/openstack/nova/commit/bfef7ee74352aa10ee7755c16431c040a73e22e8
Submitter: Jenkins
Branch: stable/havana

commit bfef7ee74352aa10ee7755c16431c040a73e22e8
Author: Gary Kotton <email address hidden>
Date: Wed Oct 9 23:35:12 2013 -0700

    VMware: fix bug for reporting instance UUID's

    Ensure that the correct UUID's are reported to the compute
    manager. The fix will return only valid UUID's and not all
    of the names of the instances running.

    Closes-Bug: #1237795

    Change-Id: I32bb6f4783dcc80697abebd5a7f45ef9950a0896
    (cherry picked from commit 74289aacb5363bd72b449580325a651117e5342d)