Fix useless vmware pause/unpause test methods

Bug #1237679 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Matt Riedemann

Bug Description

The vmwareapi test class that tests the VMwareESXDriver has a test_pause and test_unpause method that simply passes:

https://github.com/openstack/nova/blob/master/nova/tests/virt/vmwareapi/test_vmwareapi.py#L632

https://github.com/openstack/nova/blob/master/nova/tests/virt/vmwareapi/test_vmwareapi.py#L635

Those APIs aren't supported by the VMwareESXDriver so they should actually test that the code raises NotImplementedError.

https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L957

https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L961

I think the test class was doing a pass for the esx driver because the test class for the vcdriver extends the esx driver test class, but the method isn't any different for the vcdriver test class so it should just assert it raises NotImplementedError either way.

Tags: testing vmware
Matt Riedemann (mriedem)
summary: - Fix useless vmware test methods
+ Fix useless vmware pause/unpause test methods
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50780

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/50780
Committed: http://github.com/openstack/nova/commit/dced1df98e385ebb0615d3789f67d95add49c637
Submitter: Jenkins
Branch: master

commit dced1df98e385ebb0615d3789f67d95add49c637
Author: Matt Riedemann <email address hidden>
Date: Wed Oct 9 16:19:21 2013 -0700

    Make the vmware pause/unpause unit tests actually test something

    The pause/unpause tests for vmware were just passing so this patch
    actually makes them test the pause/unpause methods for the
    VMwareESXDriver and VMwareVCDriver classes.

    Closes-Bug: #1237679

    Change-Id: Idf7c6e6f9542b9ab4dd2ab710597f1a198889dfa

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.