vmware driver is not actually implementing get_diagnostics
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Matt Riedemann |
Bug Description
According to the hypervisor support matrix the vmware driver doesn't support the diagnostics API:
https:/
But the code suggests otherwise:
https:/
https:/
There is an unused get_diagnostics method in vmwareapi.vmops though:
https:/
i'm guessing that was stubbed out before the get_info method was added and someone connected the dots to the vmwareapi driver code to use it.
We should remove the unused get_diagnostics method.
Note that there aren't actually really any unit tests associated with the vmwareapi diagnostics API support though so we should add that in when we remove the unused method.
Changed in nova: | |
milestone: | none → icehouse-1 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-1 → 2014.1 |
Actually it looks like the vmwareapi.driver code is calling get_info for both the get_info API and the get_diagnostics API but they are supposed to return different information, so the vmware driver is actually not supporting the diagnostics API and should be fixed to raise the NotImplementedE rror.