DPR should be automatically adjusted to the correct value in UbuntuWebView
Bug #1237348 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
In the current implementation, the DPR is set from the value of the QTWEBKIT_DPR environment variable when the browser application is started. This means that other client applications embedding an UbuntuWebView don’t benefit from this "fix".
Ideally this should be transparent to application developers: using an UbuntuWebView on a device, it should get the correct value of the DPR automatically. This has to be done in the plugin instead of in the application.
Related branches
lp:~osomon/webbrowser-app/dpr-in-plugin
- Bill Filler (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 123 lines (+20/-25)5 files modifiedsrc/Ubuntu/Components/Extras/Browser/UbuntuWebView.qml (+7/-5)
src/Ubuntu/Components/Extras/Browser/plugin.cpp (+13/-0)
src/app/Browser.qml (+0/-3)
src/app/webbrowser-app.cpp (+0/-16)
src/app/webbrowser-app.qml (+0/-1)
| Changed in webbrowser-app: | |
| assignee: | nobody → Olivier Tilloy (osomon) |
| Changed in webbrowser-app: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Committed |
| Changed in webbrowser-app: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| costales (costales) wrote | #1 |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #2 |
To post a comment you must log in.
Hi!
I have this issue with an BQ Ubuntu Edition, I'm thinking it could be the same problem
https:/
Thanks in advance!