horizon fails to add security group rule if hidden field has invalid value

[Russell Sim]

Hey,

I found that when you for example fill in the port field by accident
with invalid data. Then change the port_or_range selector to 'port range'
and fill in valid data in the to and from fields, the failed validation of the
port field will prevent you from successfully submitting the form.

The error message is also hidden from the user because the field that
failed to validate isn't visible.

This same problem exists when you fill in invalid port and or port_range
then change to icmp. Or insert an invalid cidr then change to the
Security Group selector.

Thanks,

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/50522

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/50522
Committed: http://github.com/openstack/horizon/commit/fa3a039d0585c8c995504c09657070af4025305f
Submitter: Jenkins
Branch: master

commit fa3a039d0585c8c995504c09657070af4025305f
Author: Russell Sim <email address hidden>
Date: Wed Oct 9 12:54:41 2013 +1100

    Ignore irrelevant secgroup form field errors

    When cleaning data from in the security group rule form, remove any
    associated error messages that are not related to the actual fields
    being saved. If we are setting a value derived from another field, also
    delete the error message associated with that field.

    Change-Id: I1eb4835ea2368b62374f230c6293062a2340980d
    Closes-Bug:1237128