neutron

Fix dhcp_release lease race condition

Bug #1237028 reported by Aaron Rosen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Aaron Rosen
neutron 2013.2 "havana"

Bug Description

There is a possible race condition when delete or updating fixed_ips on ports where an instance could renew its ip address again after dhcp_release has already been executed. To fix this, the order of reload_allocation and release_lease need to be switched. This way an instance will not be able to renew it's ip address after it is removed from the host file.

Aaron Rosen (arosen)
Changed in neutron:
assignee: nobody → Aaron Rosen (arosen)
importance: Undecided → High
tags: added: havana-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50460

Changed in neutron:
status: New → In Progress
Mark McClain (markmcclain)
Changed in neutron:
milestone: none → havana-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/50460
Committed: http://github.com/openstack/neutron/commit/39b4c89353a0f7b942a2b3c849c43410a5d203ec
Submitter: Jenkins
Branch: master

commit 39b4c89353a0f7b942a2b3c849c43410a5d203ec
Author: Aaron Rosen <email address hidden>
Date: Tue Oct 8 12:24:21 2013 -0700

    Fix dhcp_release lease race condition

    There is a possible race condition when delete or updating fixed_ips
    on ports where an instance could renew its ip address again after
    dhcp_release has already been executed. To fix this, the order of
    reload_allocation and release_lease need to be switched. This way an
    instance will not be able to renew it's ip address after it is
    removed from the host file.

    Fixes bug: 1237028

    Change-Id: If05ec2be507378c634f5c1856dab0fbd396f43cc

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/51005

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (milestone-proposed)

Reviewed: https://review.openstack.org/51005
Committed: http://github.com/openstack/neutron/commit/ba99783a80ee0f92135dcfd562f3cfc9dad46d86
Submitter: Jenkins
Branch: milestone-proposed

commit ba99783a80ee0f92135dcfd562f3cfc9dad46d86
Author: Aaron Rosen <email address hidden>
Date: Tue Oct 8 12:24:21 2013 -0700

    Fix dhcp_release lease race condition

    There is a possible race condition when delete or updating fixed_ips
    on ports where an instance could renew its ip address again after
    dhcp_release has already been executed. To fix this, the order of
    reload_allocation and release_lease need to be switched. This way an
    instance will not be able to renew it's ip address after it is
    removed from the host file.

    Fixes bug: 1237028

    Change-Id: If05ec2be507378c634f5c1856dab0fbd396f43cc

Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.