change alarm_history.detail column type to Text

Bug #1236861 reported by Stephen Gran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Stephen Gran

Bug Description

The metadata sent in a query that ends up in alarm_history.detail easily exceeds 255 characters on all but the most trivial updates. Used with heat and autogenerated names/URLs, the limit is impossible to work with. Please change to type text.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50351

Changed in ceilometer:
assignee: nobody → Stephen Gran (sgran)
status: New → In Progress
Julien Danjou (jdanjou)
Changed in ceilometer:
milestone: none → havana-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/50351
Committed: http://github.com/openstack/ceilometer/commit/57eb9e904aacae166d7265a914960415c57cd133
Submitter: Jenkins
Branch: master

commit 57eb9e904aacae166d7265a914960415c57cd133
Author: Stephen Gran <email address hidden>
Date: Tue Oct 8 14:29:47 2013 +0100

    Change alarm_history.detail to text type

    The existing alarm_history.detail column size is 255 chars,
    which is not enough for some large JSON payloads.

    Change to Text column to make sure we store all detail.

    Change-Id: I1b4ebee33954acc1f41a4cf0d0b991055b7d4fe9
    Closes-Bug: #1236861
    Signed-off-by: Stephen Gran <email address hidden>

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/51388

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (milestone-proposed)

Reviewed: https://review.openstack.org/51388
Committed: http://github.com/openstack/ceilometer/commit/c7b645dbc14ad84f2b8b9415d79a98b5822e8fc5
Submitter: Jenkins
Branch: milestone-proposed

commit c7b645dbc14ad84f2b8b9415d79a98b5822e8fc5
Author: Stephen Gran <email address hidden>
Date: Tue Oct 8 14:29:47 2013 +0100

    Change alarm_history.detail to text type

    The existing alarm_history.detail column size is 255 chars,
    which is not enough for some large JSON payloads.

    Change to Text column to make sure we store all detail.

    Closes-Bug: #1236861
    Signed-off-by: Stephen Gran <email address hidden>
    (cherry picked from commit 57eb9e904aacae166d7265a914960415c57cd133)

    Change-Id: I1460c2a5bbd5cb465a605bb80775853468148026

Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.