swift_get_container should use swiftclient.head_container()

Bug #1236677 reported by Kieran Spear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Lin Hua Cheng

Bug Description

This method is just getting the metadata for the container and never using the data that's returned:

def swift_get_container(request, container_name):
    headers, data = swift_api(request).get_object(container_name, "")

Should probably be:

    headers = swift_api(request).head_container(container_name)

Kieran Spear (kspear)
description: updated
Changed in horizon:
status: New → Confirmed
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
importance: Undecided → Low
milestone: none → icehouse-1
Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

Good catch! Thanks!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50483

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/50483
Committed: http://github.com/openstack/horizon/commit/22e8f839d198b6930faa2759c136f3b279010fd8
Submitter: Jenkins
Branch: master

commit 22e8f839d198b6930faa2759c136f3b279010fd8
Author: Lin Hua Cheng <email address hidden>
Date: Tue Oct 8 14:08:38 2013 -0700

    Use HEAD when retrieving Container details

    Change-Id: I0bb41bbf2ec8b0a515aa8a9ee9eba63761a60122
    Closes-bug: 1236677

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.