Disable H803: git commit title should not end with period

Bug #1236621 reported by Kieran Spear
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Kieran Spear
hacking
Opinion
Undecided
Unassigned

Bug Description

I think it's a total waste of reviewing time and gating resources for patches to be failing because of a period at the end of a commit title. This makes no difference at all to readability. I propose we disable the check.

See here for an example:
https://review.openstack.org/#/c/50167

Dolph Mathews (dolph)
affects: python-keystoneclient → hacking
Kieran Spear (kspear)
affects: hacking → horizon
Revision history for this message
Kieran Spear (kspear) wrote :
Changed in horizon:
status: New → In Progress
assignee: nobody → Kieran Spear (kspear)
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

i suggest you should keep Dolph Mathews change, it is a hacking problem, either enhance it while do pep8 check locally or remove it

Revision history for this message
Kieran Spear (kspear) wrote :

commit 23ca27afbe470db435b33eecd5d674620a72bdc5
Author: Kieran Spear <email address hidden>
Date: Tue Oct 8 13:03:41 2013 +1100

    Disable H803 check.

    H803: Git commit title should not end with period.

    I don't think we really care whether a commit title ends with a period
    or not. Certainly not enough to warrant patches failing checks and
    wasting people's time and CI resources.

    Change-Id: I52fd73c35545943b1a7e2cec62ddb52a5f90a24b
    Closes-bug: 1236621.

Changed in horizon:
status: In Progress → Fix Committed
importance: Undecided → Low
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

I agree this might be a restriction no one cares about.
I'd like to see other's opinions on this before proceeding with the fix

Changed in neutron:
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Andrew Lazarev (alazarev) wrote :

+1 on "remove check"

Revision history for this message
Joe Gordon (jogo) wrote :

Here is part of the backstory, http://lists.openstack.org/pipermail/openstack-dev/2013-June/010837.html

While I personally don't like the rule, I don't feel comfortable removing it unless at least half of the integrated projects agree it should be removed.

Changed in hacking:
status: New → Opinion
Changed in neutron:
status: Incomplete → Won't Fix
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This doesn't affect Neutron at all, afaik, and I haven't seen a commit message fail on a trailing period for a long time.

Changed in neutron:
status: Won't Fix → Invalid
no longer affects: neutron
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.