Resize Usage Events should use DB timestamp

Bug #1236620 reported by Justin Hopper
34
This bug affects 5 people
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Critical
Justin Hopper

Bug Description

In order to keep accurate record of when the instance or volume was resized, we should use the same timestamp for both the database record and for the usage event. Currently, while they are captured in close proximity of time, they are not the same value and can drift by a second or so.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50192

Changed in trove:
assignee: nobody → Justin Hopper (justin-hopper)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/50192
Committed: http://github.com/openstack/trove/commit/ad3714c9c83487f46044eb4122f08a9127561b77
Submitter: Jenkins
Branch: master

commit ad3714c9c83487f46044eb4122f08a9127561b77
Author: justin-hopper <email address hidden>
Date: Mon Oct 7 16:21:57 2013 -0700

    Fix Timestamps for Resize Usage Events

        Timestamps should be in-sync between database and usage event

    Fixes: Bug 1236620
    Change-Id: Iff7c2431def6607968fbfcfb04c6f0daec0d03af

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
status: Fix Committed → Confirmed
importance: Undecided → Critical
Changed in trove:
milestone: none → icehouse-1
Revision history for this message
Michael Basnight (hubcap) wrote :

fwiw, im still seeing this, thats why i reopened.

Revision history for this message
Craig Vyvial (cp16net) wrote :

I just saw it.

Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-1 → icehouse-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/61590

Changed in trove:
assignee: Justin Hopper (justin-hopper) → Robert Myers (rmyers)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/61590
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=14b3eaa087a86250bfd44e01bff515839c8fa521
Submitter: Jenkins
Branch: master

commit 14b3eaa087a86250bfd44e01bff515839c8fa521
Author: Robert Myers <email address hidden>
Date: Wed Dec 11 16:35:38 2013 -0600

    Fix deleted_at timestamp in usage tests

    * use the mgmt api to look up the instance for the deleted_at time

    Closes-Bug: 1236620

    Change-Id: I96d46f9f48616124f59efeb1292cfe0768b6318c

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
status: Fix Committed → Confirmed
Revision history for this message
Nikhil Manchanda (slicknik) wrote :

This is still an issue with the resize event, and juice is working on a fix.
For a repro (and the logs) please take a look at:
http://logs.openstack.org/90/61590/2/gate/gate-trove-python27/4ca0a48/console.html

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66063

Changed in trove:
assignee: Robert Myers (rmyers) → Justin Hopper (justin-hopper)
status: Confirmed → In Progress
Changed in trove:
milestone: icehouse-2 → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/70313

Changed in trove:
milestone: icehouse-3 → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/70313
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=11ca746c3cd69fe07bc2fc4a1d5d9bb2a27d73a5
Submitter: Jenkins
Branch: master

commit 11ca746c3cd69fe07bc2fc4a1d5d9bb2a27d73a5
Author: justin-hopper <email address hidden>
Date: Mon Mar 3 23:24:40 2014 -0800

    Fix Timestamp diff in Instance and Notification

        Code is updating timestamp to clear out task status after it
        has already completed the task and updated the instance db
        info. Made this an single transaction so that the timestamp
        in the db matches the actual action and the notification

    Closes-Bug: 1236620

    Change-Id: Iaa59f6e6d0b958e79b0491bfa2a838f5896d9705

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.