BooleanIndex index becomes wrong when index value is inverted during a RE-indexation

[Thomas Desvenain]

This test (for now in tdesvenain fork) fails :
self.assertEqual(list(res), [1, 3, 4]) is wrong because '1' document is always indexed with False value

    def test_reindexation_when_index_reversed(self):
        index = self._makeOne()
        obj1 = Dummy(1, False)
        index._index_object(obj1.id, obj1, attr='truth')
        obj2 = Dummy(2, False)
        self.assertTrue(index._index_value)
        index._index_object(obj2.id, obj2, attr='truth')
        obj3 = Dummy(3, True)
        index._index_object(obj3.id, obj3, attr='truth')
        obj4 = Dummy(4, True)
        index._index_object(obj4.id, obj4, attr='truth')
        obj1.truth = True
        index._index_object(obj1.id, obj1, attr='truth')
        self.assertFalse(index._index_value)

        res = index._apply_index({'truth': True})[0]
        self.assertEqual(list(res), [1, 3, 4])

[Thomas Desvenain (thomas-desvenain)]

AssertionError: Lists differ: [3, 4] != [1, 3, 4]

First differing element 0:
3
1

Second list contains 1 additional elements.
First extra element 2:
4

- [3, 4]
+ [1, 3, 4]
? +++

[Thomas Desvenain (thomas-desvenain)]

I work on this bug there :
https://github.com/tdesvenain/Products.ZCatalog

But i need some help... :)

[Thomas Desvenain (thomas-desvenain)]

I submited a pull request

[Tres Seaver (tseaver)]

PR merged:

  https://github.com/zopefoundation/Products.ZCatalog/pull/2

[Thomas Desvenain (thomas-desvenain)]

Fixed in master

[Hanno Schlichting (hannosch)]

Released in 3.0.1 / 2.13.25.