OpenStack Heat

global template resources are overridden by plugins

Bug #1236107 reported by Angus Salkeld
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Angus Salkeld
OpenStack Heat 2013.2 "havana"

Bug Description

The order of loading global resources is incorrect. At the moment template resources are loaded first then python plugins are loaded. If a deployer is providing a custom template resource then this will be overridden by the python plugin.
Basically template resource defined in the global env need to be honored.

Angus Salkeld (asalkeld)
Changed in heat:
assignee: nobody → Angus Salkeld (asalkeld)
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49979

Changed in heat:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/49980

Steve Baker (steve-stevebaker)
Changed in heat:
milestone: none → havana-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/49979
Committed: http://github.com/openstack/heat/commit/504bd0c815e30829c604ae1f29bf8bd8323ca1ae
Submitter: Jenkins
Branch: master

commit 504bd0c815e30829c604ae1f29bf8bd8323ca1ae
Author: Angus Salkeld <email address hidden>
Date: Mon Oct 7 22:04:37 2013 +1100

    Make the testing of resource loading easier

    Pass an environment object around so tests don't have
    to use the global object and then conflict with other tests.

    Change-Id: I0d9a0d3bd825ac415847213ee4a5d7473f80dbd6
    Partial-bug: #1236107

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/49980
Committed: http://github.com/openstack/heat/commit/510299bed35456ea0a5b6c0cbab9660fdf1cbc36
Submitter: Jenkins
Branch: master

commit 510299bed35456ea0a5b6c0cbab9660fdf1cbc36
Author: Angus Salkeld <email address hidden>
Date: Mon Oct 7 13:12:04 2013 +1100

    Move the registration of the global env to after plugin resources

    This prevents a user's template resources from getting overridden
    by a resource plugin.

    Change-Id: Idd1a5155dd28d662df8cdc44d190e24c84fd7a81
    Closes-bug: #1236107

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/50581

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/50582

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (milestone-proposed)

Reviewed: https://review.openstack.org/50581
Committed: http://github.com/openstack/heat/commit/95d6be25f472f02e96ab8bab8c0c57b792615899
Submitter: Jenkins
Branch: milestone-proposed

commit 95d6be25f472f02e96ab8bab8c0c57b792615899
Author: Angus Salkeld <email address hidden>
Date: Mon Oct 7 22:04:37 2013 +1100

    Make the testing of resource loading easier

    Pass an environment object around so tests don't have
    to use the global object and then conflict with other tests.

    Change-Id: I0d9a0d3bd825ac415847213ee4a5d7473f80dbd6
    Partial-bug: #1236107

Changed in heat:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/50582
Committed: http://github.com/openstack/heat/commit/d0dc6843f1ed42cb5b4b4cde76a334706168e491
Submitter: Jenkins
Branch: milestone-proposed

commit d0dc6843f1ed42cb5b4b4cde76a334706168e491
Author: Angus Salkeld <email address hidden>
Date: Mon Oct 7 13:12:04 2013 +1100

    Move the registration of the global env to after plugin resources

    This prevents a user's template resources from getting overridden
    by a resource plugin.

    Change-Id: Idd1a5155dd28d662df8cdc44d190e24c84fd7a81
    Closes-bug: #1236107

Thierry Carrez (ttx)
Changed in heat:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.