pkg_name calculated incorrectly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Thumbnailer |
Fix Released
|
Undecided
|
Unassigned | ||
thumbnailer (Ubuntu) |
Fix Released
|
Critical
|
Unassigned | ||
Saucy |
Fix Released
|
Critical
|
Unassigned |
Bug Description
get_app_pkg_name() parses the value of /proc/self/
Oct 4 14:47:00 localhost kernel: [ 2456.617111] type=1400 audit(138091602
The app's apparmor label is "net.launchpad.
/home/jamie/
however is actually uses:
/home/jamie/
This can perhaps be seen more clearly with the attached test program. Steps to reproduce:
$ cat > /tmp/bug.profile <<EOM
#include <tunables/global>
profile test_me {
file,
}
EOM
$ sudo apparmor_parser -r /tmp/bug.profile
$ g++ /tmp/bug.cpp -o /tmp/bug
$ aa-exec -p test_me -- /tmp/bug
/proc/self/
app_pkg_name=tes
$
In addition to the above, get_app_pkg_name() is not careful enough in determining the package name. It should throw an error if the value of /proc/self/
^[a-z0-
(see https:/
/usr/
/usr/
/opt/foo/_bar
Related branches
- Jamie Strandboge: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/thumbnailcache.cpp (+1/-1)
- Michi Henning (community): Disapprove
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 53 lines (+15/-8)2 files modifieddebian/control (+1/-0)
src/thumbnailcache.cpp (+14/-8)
description: | updated |
summary: |
- off by one when calculating pkgname + pkg_name calculated incorrectly |
Changed in thumbnailer: | |
status: | Fix Committed → Fix Released |
Changed in thumbnailer: | |
status: | Confirmed → Fix Released |
Fix committed into lp:thumbnailer at revision 54, scheduled for release in thumbnailer, milestone Unknown