Footprint Save not honouring plugin type

[Dick Hollenbeck]

With BUILD_GITHUB_PLUGIN and USE_FP_LIB_TABLE enabled, version 4362:

Use module editor to load a GITHUB_PLUGIN footprint, modify it and save it, I get a confusing error message that proves the wrong FootprintSave() function is being called to save the footprint.

IO_ERROR: Footprint library path <https:/github.com/liftoff-sr/pretty_footprints> does not exist
from /svn/kicad/testing.checkout/pcbnew/kicad_plugin.cpp : Load() : line 254

1) The kicad_plugin should not be in the picture since the fp_lib_table has plugin type as "Github".

2) The save should not even have been attempted since the PLUGIN returns false to
PLUGIN::IsFootprintLibWritable()

[Wayne Stambaugh (stambaughw)]

I committed a fix in r4375 that should fix this problem. Unfortunately I don't have write access to a github repo so I cannot test the fix. However, the second '/' character is no longer stripped from the uri in PCB_EDIT_FRAME::Select_Active_Library() so it should work. Please let me know if you are still having problems.