xenapi: clean up step decorator fake steps

[John Garbutt]

In migrate_disk_resize_up in VMOps we have a "fake step".

We should just add something to increment the initial count, thats much neater, and stops us having unreached code, etc.

[guillaume thouvenin (guillaume-thouvenin)]

I take this bug report in order to familiarize myself with the code and with the hope to help fixing it but I don't see any function migrate_disk_resize_up in the current code.

Is this bug up-to-date?

[Bob Ball (bob-ball)]

Not quite - it seems as though things have been moved / renamed.

The step is in vmops.py and called "fake_step_to_be_executed_by_finish_migration".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/63109

[Sahid Orentino (sahid-ferdjaoui)]

I also add in the review a missing test for a successful resize_down.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/63109
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=794027c520935d9a6ba1475aaa128b281b924630
Submitter: Jenkins
Branch: master

commit 794027c520935d9a6ba1475aaa128b281b924630
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Thu Dec 19 13:06:18 2013 +0000

    xenapi: clean up step decorator fake steps

    In vmops.py there are some fake methods to adjust the number
    of steps used for a resize up/down.

     + This patch adds to the method used to create steps a new parameter
       'total_offset' to adjust the offset of total steps.
     + This patch also adds a missing test for a successful resize down.

    Change-Id: I506045442d893e91b03ce33e4aab9930966c8ec2
    Closes-Bug: 1235108