can't reset background to default

Bug #1234994 reported by Jamie Strandboge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gallery-app
Invalid
Undecided
Unassigned
ubuntu-system-settings
Fix Released
Low
Unassigned
ubuntu-system-settings (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Setting the background works great, however, after I set a picture, I can't undo the action. Ie, if I set a picture, I can't go back and set it to the default.

Tags: avengers

Related branches

Revision history for this message
Iain Lane (laney) wrote :

IMO the gallery app could show the default (and some stock wallpapers)

summary: - can't undo setting the background
+ can't reset background to default
Revision history for this message
Sebastien Bacher (seb128) wrote :

Hey mpt, do you have any opinion on that?

Changed in ubuntu-system-settings:
assignee: nobody → Matthew Paul Thomas (mpt)
importance: Undecided → Low
Iain Lane (laney)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Matthew Paul Thomas (mpt)
importance: Undecided → Low
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This is already specced: the default image should be in the "Ubuntu Art" section, so you can reselect it.

Changed in ubuntu-system-settings:
assignee: Matthew Paul Thomas (mpt) → nobody
status: New → Triaged
Revision history for this message
Matthew Paul Thomas (mpt) wrote :
Changed in ubuntu-system-settings (Ubuntu):
assignee: Matthew Paul Thomas (mpt) → nobody
status: New → Triaged
Revision history for this message
Sebastien Bacher (seb128) wrote :

Well, that design came late for v1, I guess it's going to be an issue to resolve for next cycle...

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Since the background selection page looks anyway different right now, how about we include a button 'use default background' or 'revert to default' that's below the selection screen? This would be a temporary solution, but that's better than nothing I guess.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Screenshot of the quick workaround

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Thanks Łukasz. Unfortunately that makes the button the only obviously interactive thing on the screen -- strongly suggesting that resetting the background is the only thing you can do!

As long as this is temporary, could you add two buttons instead of one?
- "Change…", which would do the same as tapping on the image
- "Use Original Background", which would reset.

Make sure the "Use Original Background" button is insensitive whenever the current image *is* the original.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thank you for your comment! I have taken those things into consideration - submitting a screenshot of the current looks. Hope it's feasible.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work Łukasz, I did a code review and commented on the merge request, some UI comments:

- the divider lines look weird, we should probably hide those

- the spacing/alignment of the buttons look weird to me. It feels like that the space between the image and the button should be at least the same than between the top divider and the image, and that the left/right borders should be aligned either on the image or on the borders of the screen ...

I'm not a designer though ... mpt, what do you think?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-system-settings at revision 445, scheduled for release in ubuntu-system-settings, milestone Unknown

Changed in ubuntu-system-settings:
status: Triaged → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :
Changed in ubuntu-system-settings:
status: Fix Committed → Fix Released
Changed in ubuntu-system-settings (Ubuntu):
status: Triaged → Fix Released
Omer Akram (om26er)
Changed in gallery-app:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.