links to images broken in image gallery

[Dirk Meyer]

1.8RC1, Debian, Mysql
I added images to a folder
I added a image galleryblock to a page and chose to display the folder with the images

The images work as expected when used as a image gallery. The bug is when I click the title of the gallertblock. This will show a page with three columns; name, description, date. The hyperlinks to the images from this page are broken.

[Aaron Wells (u-aaronw)]

Hi Dirk,

Thanks for the bug report, and thanks for testing the release candidate!

Cheers,
Aaron

[Kristina Hoeppner (kris-hoeppner)]

patch at https://reviews.mahara.org/2576

No ID change necessary as translators don't need to see this change. This is purely for English.

[Kristina Hoeppner (kris-hoeppner)]

Ignore that last comment. It was meant for bug #1230044.

[Robert Lyon (robertl-9)]

Son Nguyen - I'm not sure if you've started on this or not but you might want to checkout this patch
https://reviews.mahara.org/#/c/2579/

that was for a similar problem with gallery image links to see if it fixes this problem also

[Son Nguyen (ngson2000)]

Hi Robert;

Yes, your patch will fix this bug

Thanks

[Robert Lyon (robertl-9)]

Actually the problem might be resolved with

https://reviews.mahara.org/#/c/2577/

The image artefacts don't have blockinstance ids (as they are part of a parent blockinstance) and they were being passed through a function to get their blockinstance title and was throwing error if block instance didn't exist.

Have made it so only artefacts that have block id passed as well use the function.

[Aaron Wells (u-aaronw)]

Yep, that commit fixes the problem.